fix(daemon-control): stabilize macOS service resolution - #770
Open
BleedingDev wants to merge 3 commits into
Open
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…/pr707-macos-path-shadow-e8e30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchctloridshadowsServiceRunnercompile failureWhy
The pinned #707 head does not compile its daemon-control tests on macOS because an ungated test uses a Linux-gated import. After fixing that blocker, one fixture reads the host's real launchd state. PATH lookup also incorrectly treats an unusable early entry as terminal.
Based on #707 commit
e8e30fb323ebdfb53380b682ef6aba5a5c384979.Verification
cargo test -p tracedecay-daemon-control --lib --lockedlaunchctlandid