Skip to content

fix(daemon-control): stabilize macOS service resolution - #770

Open
BleedingDev wants to merge 3 commits into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:fix/pr707-macos-path-shadow-e8e30
Open

fix(daemon-control): stabilize macOS service resolution#770
BleedingDev wants to merge 3 commits into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:fix/pr707-macos-path-shadow-e8e30

Conversation

@BleedingDev

Copy link
Copy Markdown
Contributor

Summary

  • continue PATH lookup past non-executable launchctl or id shadows
  • preserve strict rejection for explicitly injected absolute program paths
  • fix the macOS test-module ServiceRunner compile failure
  • isolate service-unit advice tests from the developer's real LaunchAgents directory

Why

The pinned #707 head does not compile its daemon-control tests on macOS because an ungated test uses a Linux-gated import. After fixing that blocker, one fixture reads the host's real launchd state. PATH lookup also incorrectly treats an unusable early entry as terminal.

Based on #707 commit e8e30fb323ebdfb53380b682ef6aba5a5c384979.

Verification

  • cargo test -p tracedecay-daemon-control --lib --locked
  • 81 passed, 0 failed
  • deterministic PATH tests for both launchctl and id
  • explicit-path rejection test

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fed1a08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T16:59:09.659092Z fb6d698 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants