feat(hotpath): fill agent-hosts hook dispatch/store gaps - #777
Draft
ScriptedAlchemy wants to merge 4 commits into
Draft
feat(hotpath): fill agent-hosts hook dispatch/store gaps#777ScriptedAlchemy wants to merge 4 commits into
ScriptedAlchemy wants to merge 4 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Contributor
Performance Comparison
|
…sor/hp-hosts-dispatch-store-gaps-b158
…sor/hp-hosts-dispatch-store-gaps-b158
…sor/hp-hosts-dispatch-store-gaps-b158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the remaining
#[hotpath::measure]coverage gaps incrates/tracedecay-agent-hostsonly (HP-hosts). Attribute-only change: 38 added lines, zero behavior changes, no Cargo.toml edits, nohotpath/tokio, hotpath stays off in default/production builds (macros expand to no-ops without the opt-inhotpathfeature).New labels follow the crate's established
agent_hosts.<area>.<verb>convention (as inagents/mod.rs). No existing#[hotpath::measure]was restamped;tracedecay-hooksandtracedecay-host-integrationare untouched.Instrumented call sites
ports/hook_runtime.rs(was no-hp):daemon_tool_json,resolve_project_root_with_identity,resolve_hook_scope,notify_hook_event,is_project_initialized(fs-backed fallback),resolve_store_layout—agent_hosts.hook_runtime.*. Register setters and pure gate getters skipped.hooks/daemon_ports.rs(was no-hp):daemon_admission_responsedecode,timed_daemon_hook_action,DaemonDeliveryReceiptPort::post_receipt,DaemonOpenCodeLspUpdatePort::submit_updated_event—agent_hosts.hook_ports.*. Boxed-future trait methods (try_admit_async,deliver_hook_v2) are not fn-level measurable without measuring only future construction; their inner daemon round trip is already covered byhosts.hooks.daemon_actionplus the helpers above.hooks/kiro.rs(was no-hp):hook_kiro_pre_tool_use,hook_kiro_prompt_submit,hook_kiro_post_tool_use—agent_hosts.hooks.kiro.*.hooks/cursor_compact.rs(was no-hp):cursor_pre_compact_via_daemon_with_telemetry—agent_hosts.hooks.cursor.compact_via_daemon(the thin pub wrapper is skipped to avoid double counting).agents/context_scout_model.rs(was no-hp):context_scout_model_assistant_from_automation_config(includes the backend availability probe),backend_request,response_to_proposal—agent_hosts.context_scout.*. Trivial mappers/schema/cost helpers skipped;proposereturns a boxed future whose blocking backend work runs inspawn_blocking.hooks/mod.rs(add-missing only):dispatch_kimi_event,dispatch_opencode_event,dispatch_opencode_tool_after—agent_hosts.hooks.dispatch_*.native_integration/store.rs(add-missing only): all 18 actor round-trip operations onDaemonNativeIntegrationStore(save_approval/read_approvalplus the fullNativeIntegrationStoretrait impl) —agent_hosts.native_store.*.submit/await_replyinternals,shutdown, the long-livedrun_store_actorloop, and the pure-delegationSharedDaemonNativeIntegrationStorewrappers are skipped.agents/host_bundle_v2.rstrivia intentionally skipped per plan/evidence.Verification
cargo check -p tracedecay-agent-hosts— passes (default features, macros no-op).cargo check -p tracedecay-agent-hosts --features hotpath— passes (instrumentation expanded).cargo test -p tracedecay-agent-hosts— 603 passed, 2 failed. Both failures (native_integration::journey_tests::{foreign_destination_ref_drift_terminates_without_mutating_the_foreign_tip, independent_pair_applies_supported_modes_and_survives_daemon_restart}) fail identically on the unmodified base commit10403bb2dof the feat: consolidate TraceDecay V2 PR8-PR13 delivery #707 branch (SigningRequired/ preview-approval contract), so they are pre-existing on the base and unrelated to this attribute-only diff.lint:commitfailures on this branch come from pre-existingmerge:subjects already on the feat: consolidate TraceDecay V2 PR8-PR13 delivery #707 base branch.Do not merge #707 as part of this PR; this targets it as base only.