feat(hotpath): fill rusqlite-runtime execute/query gaps - #778
Draft
ScriptedAlchemy wants to merge 4 commits into
Draft
feat(hotpath): fill rusqlite-runtime execute/query gaps#778ScriptedAlchemy wants to merge 4 commits into
ScriptedAlchemy wants to merge 4 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
…sor/hotpath-gap-fill-8c00
Contributor
Performance Comparison
|
…sor/hotpath-gap-fill-8c00
…sor/hotpath-gap-fill-8c00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gap-fill hotpath instrumentation PR for
crates/tracedecay-rusqlite-runtimeonly (HP-db-sqlite), stacked on #707. Adds 56 new#[hotpath::measure]sites on previously unmeasured SQL execution, transaction, reader-lease, and recovery-authority paths. No existing measure site was renamed, moved, or rewritten; the diff is insertions only (56 added lines, 0 removed).crate.area.verbgrammar (rusqlite.<area>.<verb>).hotpath/hotpath-alloc/hotpath-cpufeature passthrough, and these features remain excluded fromdefaultandproduction. Without--features hotpathevery macro expands to a no-op.cargo check -p tracedecay-rusqlite-runtime(default) andcargo check -p tracedecay-rusqlite-runtime --features hotpathboth pass, pluscargo clippy -p tracedecay-rusqlite-runtime --all-targets --features hotpathis clean. Commit subject passeslint:commit.Files touched / new measure sites / new labels
src/repository/project.rsrusqlite.project.fact_write,rusqlite.project.observation_write,rusqlite.project.observation_batch,rusqlite.project.remote_observation_replay,rusqlite.project.observation_cursor_advance,rusqlite.project.evidence_assembly_write,rusqlite.project.readsrc/repository/diagnostics.rsrusqlite.diagnostics.write,rusqlite.diagnostics.supersede,rusqlite.diagnostics.read,rusqlite.diagnostics.chain_walk,rusqlite.diagnostics.insert_recordsrc/repository/retrieval_anchor.rsrusqlite.retrieval_anchor.disposition_write,rusqlite.retrieval_anchor.derivative_write,rusqlite.retrieval_anchor.read,rusqlite.retrieval_anchor.current_recordsrc/repository/configuration.rsrusqlite.configuration.write,rusqlite.configuration.read,rusqlite.configuration.insert_revisionsrc/repository/remote.rsrusqlite.remote.fence_verify_seed,rusqlite.remote.observation_event_persist,rusqlite.remote.fence_installsrc/remote/recovery_authority.rsrusqlite.recovery.publish_authority,rusqlite.recovery.reconcile_promotions,rusqlite.recovery.seed_authority,rusqlite.recovery.promotion_pending,rusqlite.recovery.execute_operation,rusqlite.recovery.load_writer,rusqlite.recovery.load_writer_lineage,rusqlite.recovery.promote,rusqlite.recovery.authority_state,rusqlite.recovery.persist_sink_receiptssrc/reader/pool/lease.rsrusqlite.reader_lease.begin_snapshot,rusqlite.reader_lease.execute,rusqlite.reader_lease.exact_sql_query,rusqlite.reader_lease.begin_exact_sql_snapshot,rusqlite.reader_lease.exact_sql_snapshot_query,rusqlite.reader_lease.store_size,rusqlite.reader_lease.table_sizes,rusqlite.reader_lease.finish_snapshotsrc/reader/pool/mod.rsrusqlite.reader_pool.release_memory,rusqlite.reader_pool.retire_idle,rusqlite.reader_pool.add_workersrc/exact_sql/mod.rsrusqlite.exact_sql.checkpoint_wal_truncate,rusqlite.exact_sql.release_memory,rusqlite.exact_sql.repair_auto_vacuum,rusqlite.exact_sql.txn_commit,rusqlite.exact_sql.txn_rollback,rusqlite.exact_sql.txn_dispatch,rusqlite.exact_sql.attach_db,rusqlite.exact_sql.detach_db,rusqlite.exact_sql.execute_batchsrc/connection/mod.rsrusqlite.connection.verify_identitysrc/writer.rsfuture = true)rusqlite.writer.bounded_incremental_vacuum,rusqlite.writer.enqueue_online_backupsrc/work/sql.rsrusqlite.work.queryPlacement notes for review
ProjectExecutor; converselyProjectExecutorcovers the lanes whose leaf executors are unmeasured (fact, observation, evidence assembly). Diagnostics/retrieval-anchor/configuration lanes are measured at their leaf executor files instead of theproject.rswrappers.exact_sqltransaction commit/rollback/dispatch and the writer's vacuum/backup enqueues are measured on the caller side; the existing worker-side spans (rusqlite.commit,rusqlite.exact_sql.vacuum,rusqlite.writer.online_backup) stay untouched, so the delta between the two populations exposes writer-actor queue wait, mirroring the existingbegin_immediate/write_locksplit documented in the code.submitwas left unmeasured because it delegates directly to the already-measuredsubmit_authorized;snapshot_to/snapshot_to_interruptibleare covered by the sharedenqueue_online_backupspan.rusqlite.reader_lease.finish_snapshotcovers the snapshot-end rollback wait including the deferred-return grace path.Constraints honored
crates/tracedecay-rusqlite-runtimechanged; no other crate or workspaceCargo.tomltouched.hotpath*features remain opt-in only (never indefault/production).codex/tracedecay-total-redesign-plan-reopened; feat: consolidate TraceDecay V2 PR8-PR13 delivery #707 is not merged and master is not targeted.