feat(hotpath): fill global-db schema/session/transcript gaps - #780
Draft
ScriptedAlchemy wants to merge 4 commits into
Draft
feat(hotpath): fill global-db schema/session/transcript gaps#780ScriptedAlchemy wants to merge 4 commits into
ScriptedAlchemy wants to merge 4 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
…sor/hotpath-global-db-gaps-5f1c
Contributor
Performance Comparison
|
…sor/hotpath-global-db-gaps-5f1c
…sor/hotpath-global-db-gaps-5f1c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills the remaining hotpath coverage gaps in
crates/tracedecay-global-db(HP-global) only. Adds#[hotpath::measure(future = true, label = ...)]spans to previously unmeasured async production functions; no other crate is touched andCargo.tomlfeatures are unchanged (already wired). All macros are no-ops without--features hotpath; the feature stays out ofdefault/production. Getters,Displayimpls, tests,_for_test/_with_engine(cfg(test)) helpers, and trivial one-line delegators are skipped. In the observation-projection mixed file, only the two productionpersist_projection_*_on_databasehelpers were missing spans (project_observationwas already measured), so only those were added.Files and new labels
global_db.prefix)schema_contract/validation.rsschema_contract.validate.table,schema_contract.validate.indexes,schema_contract.validate.trigger,schema_contract.validate.autoincrement,schema_contract.validate.session_temporal,schema_contract.validate.projection_receipts,schema_contract.validate.graph_publication,schema_contract.query.graph_inventory,schema_contract.validate.registry,schema_contract.validate.remote_deletion,schema_contract.validate.authorityschema_contract/invariants/rows.rsschema_contract.audit.probe,schema_contract.audit.receipt_rows,schema_contract.audit.observation_rows,schema_contract.audit.source_cursor_rows,schema_contract.audit.source_cursor_chunk,schema_contract.audit.mutable_rowsschema_contract/invariants/triggers.rsschema_contract.triggers.replace,schema_contract.triggers.contracts_intact,schema_contract.triggers.released_v3_intact,schema_contract.triggers.match_sql,schema_contract.triggers.suspend_immutability,schema_contract.triggers.restore_immutabilityschema_contract/invariants/repair.rsschema_contract.repair.read_frontier,schema_contract.repair.projection_frontier,schema_contract.repair.source_cursors,schema_contract.repair.scan_committed,schema_contract.repair.read_cursor,schema_contract.repair.write_cursor,schema_contract.repair.check_advance_receipt,schema_contract.repair.cursor_coverageregistered_sessions.rssessions.ingest_health,sessions.ingest_health_provider,sessions.has_message,sessions.message_count,sessions.project_message_count,sessions.messages_after,sessions.latest_activity,sessions.get_message,sessions.search_messages,sessions.recent_goals,sessions.workflow_factssession_temporal_handle.rssession_temporal.doctor_health,session_temporal.ensure_cursor_key,session_temporal.load_cursor_key_provider,session_temporal.load_preprovisioned_cursor_key,session_temporal.pending_refresh_page,session_temporal.materialize_refresh_batch,session_temporal.freeze_snapshot,session_temporal.summary_relations,session_temporal.apply_relation_projection,session_temporal.recover_relation_projections,session_temporal.refresh_recovery,session_temporal.complete_refreshtranscript.rstranscript.upsert_session,transcript.get_session,transcript.get_session_result,transcript.upsert_batch,transcript.persist_batch,transcript.persist_offset,transcript.upsert_projection_batches,transcript.get_parse_offset,transcript.get_parse_offset_result,transcript.set_parse_offset,transcript.advance_parse_offset,transcript.replace_parse_offset,transcript.replace_parse_offset_pairregistered/delivery_settlement.rsdelivery_settlement.query.censuses,delivery_settlement.persist.begin,delivery_settlement.persist.begin_receipted,delivery_settlement.query.source_receipt,delivery_settlement.query.pending_due,delivery_settlement.persist.settle,delivery_settlement.persist.bind_receipt,delivery_settlement.persist.fanout_identity,delivery_settlement.query.read_attempt,delivery_settlement.query.count_attempts,delivery_settlement.query.pending_censusconfiguration/store/mutation.rsconfiguration.query.idempotency_receipt,configuration.persist.mutation_receipt,configuration.query.replay_match,configuration.persist.commit,configuration.persist.commit_with_registry,configuration.persist.build_commit,configuration.query.current_state,configuration.query.replay_control,configuration.persist.commit_direct,configuration.persist.commit_direct_registryconfiguration/store/audit.rsconfiguration.audit.read_key,configuration.audit.ensure_key,configuration.audit.seal_target,configuration.audit.validate_seal,configuration.audit.insert_dry_run,configuration.audit.read_event,configuration.audit.insert_event,configuration.audit.append_terminal,configuration.audit.match_terminal,configuration.audit.read_pageobservation_projection/rebuild.rsobservation_projection.persist.retry,observation_projection.persist.rejectionVerification
cargo check -p tracedecay-global-db— passes (macros no-op, identical compile).cargo check -p tracedecay-global-db --features hotpath— passes.cargo clippy -p tracedecay-global-db --features hotpath --all-targets— clean.npm run lint:commitpasses for the new commit (pre-existingmerge:subjects on the base branch fail independently of this change).