feat(hotpath): fill session-temporal-store query/persist gaps - #781
Draft
ScriptedAlchemy wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
…sor/hotpath-session-temporal-gaps-9833
Contributor
Performance Comparison
|
…sor/hotpath-session-temporal-gaps-9833
…sor/hotpath-session-temporal-gaps-9833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the remaining hotpath coverage gaps in
crates/tracedecay-session-temporal-store(HP-temporal), instrumentation only — no behavior changes, no Cargo.toml/feature changes, and hotpath stays opt-in (every macro is a no-op without thehotpathfeature).All labels follow the existing
session_temporal.<area>.<verb>taxonomy. Getters,Displayimpls, tests,cfg(test)helpers, and pure delegations were skipped.New instrumentation
operations/message_anchor.rspublication.resolve_anchor,publication.anchor_occurrence,publication.anchor_observationstore.rsstore.persist_refresh_batch,store.persist_refresh_batch_controlled,store.refresh_recovery,store.refresh_runningquery.rsquery.read_generation,query.read_active_generation,query.read_observation,query.read_observationscursor_keys.rscursor_key.provision,cursor_key.load_active,cursor_key.load,cursor_key.keyring(sync)execution.rsexecution.validate_report,execution.authorize_task_session(sync — file is a ports/types module with no async code)retrieval/candidates.rsquery.root_authority,query.candidate_clausesql.rssql.query(aggregate over every temporal retrieval read)hydration.rs(add-missing)hydrate.authorize,hydrate.read_authorized,hydrate.decode_message,hydrate.read_occurrence,hydrate.resolve_occurrence,hydrate.resolve_summary,hydrate.summary_evidenceprojection/persist.rs(add-missing)projection.record_count,persist.occurrences,projection.canonical_occurrence,projection.require_occurrence,projection.validate_copy,projection.validate_copy_proof,persist.assertion,projection.validate_assertionNotes
refresh.rs(add-missing target) needed no changes: every entry point already carries a measure; the only unmeasured async method (persist_session_refresh_projection_batch_result) is a pure delegation to the measured controlled variant, so adding a label there would only duplicate thesession_temporal.persist.refresh_batchspan.test_registered_impls.rsskipped as instructed.operations/generation.rs.Verification
cargo check -p tracedecay-session-temporal-store(default features) — passcargo check -p tracedecay-session-temporal-store --features hotpath— pass (macros active)cargo clippy -p tracedecay-session-temporal-store --all-targets— cleancargo test -p tracedecay-session-temporal-store— 131 passed, 0 failed