feat(hotpath): fill automation-runtime retrieval/ledger gaps - #782
Draft
ScriptedAlchemy wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
…sor/hotpath-automation-runtime-gaps-63e3
…sor/hotpath-automation-runtime-gaps-63e3
…sor/hotpath-automation-runtime-gaps-63e3
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(hotpath): fill automation-runtime retrieval/ledger gaps
Summary
Fills the remaining
#[hotpath::measure]coverage gaps incrates/tracedecay-automation-runtimeonly (HP-auto). 31 new measures, all under theautomation_runtime.<area>.<verb>label scheme. Attribute-only change: every macro is a no-op with thehotpathfeature off, which stays opt-in and out ofdefault. No Cargo.toml, feature, or cross-crate changes.Previously uninstrumented files
automation/runner/retrieval.rs— session-evidence retrieval entry (retrieval.retrieve_session_evidence), outcome acceptance (retrieval.accept_outcome), anchor resolution (retrieval.resolve_anchor, async DB query), project authority binding (retrieval.bind_project_authority), and request-context minting (retrieval.mint_request_context, multi-digest construction).automation/artifacts.rs— improvement artifact chain entry (artifacts.write_improvement_chain) and per-artifact preparation (artifacts.prepare_artifact).automation/artifact_payloads.rs— the seven payload builders (artifact_payloads.build_traces/.build_feedback/.derive_generated_evals/.build_generated_evals/.build_validation_gate/.build_optimizer_diagnosis/.build_codex_handoff).automation/backend_identity.rs— identity derivation (backend_identity.derive), executable resolution (backend_identity.resolve_executable, PATH walk + open), and content digest (backend_identity.digest_executable, full binary read on cache miss).Mixed files (add-missing only; existing labels untouched)
run_ledger.rs— async loadersload_page/load_for_task_key, blocking scansscan_task_summary/scan_page/scan_filtered, and the locked appendappend_locked.run_ledger/exact_publication.rs—bind_exact,publish_exact_blocking(direct blocking callers exist alongside the already-measured async wrapper, mirroring the exact-lookup async/blocking pair),discard_exact,discard_unbound,discard_stale_exact,repair_append_intent.run_ledger/exact_lookup.rs—read_exact_identity(used by publication/binding verification).scheduler.rs—decide_host_receipt,acquire_task_lock,release_task_lock.effect_runtime/journal.rs—read_record,read_terminal,classify_settlement,check_unbound_cleanup,read_source_bindings,replay_exact_binding.skill_materialization.rs—detect_scopesplus the fs-walk interiorsscan_support_files/recompute_packageunder the already-measured reconcile/materialize entries.Getters,
Displayimpls, thin one-line delegating wrappers (e.g.find_run_record,load_latest_scheduler_effectful_for_task_key), and test code were skipped.Verification
cargo check -p tracedecay-automation-runtime— pass (feature off; macros are no-ops).cargo check -p tracedecay-automation-runtime --features hotpath— pass.cargo check -p tracedecay-automation-runtime --features hotpath --all-targets— pass.cargo test -p tracedecay-automation-runtime— 396 passed, 0 failed.Based on
codex/tracedecay-total-redesign-plan-reopened(PR #707); #707 itself is untouched.