feat(hotpath): fill query artifact/semantic/exact gaps - #786
Draft
ScriptedAlchemy wants to merge 1 commit into
Draft
feat(hotpath): fill query artifact/semantic/exact gaps#786ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/hp-query-hotpath-gaps-f2d5
branch
from
August 31, 2026 22:06
da99dcd to
51aaea1
Compare
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the remaining hotpath coverage gaps in
crates/tracedecay-query(HP-query) only. Adds missing measures; no restriping of already-instrumented files, no Cargo.toml feature changes, no changes tosrc/bin/tracedecay_index_bench.rs(CI has no span-name assertions, so new spans flow through the existinghotpath-profile.ymlworkload automatically).All labels follow
query.<area>.<verb>. Hot per-row/per-shard paths use the crate's existinghotpath_metrics::measure_frequent1-in-16 sampling helper (with_innerwrappers mirroring the existingscore_record/score_rowpattern); everything else uses#[hotpath::measure]attributes ormeasure_block!. Every macro remains a no-op without the opt-inhotpathfeature.Previously bare files
retrieval/lexical/projection/artifact/prepared.rs:query.artifact.prepare_page,query.artifact.prepare_receipt, sampledquery.artifact.prepare_documentretrieval/lexical/projection/artifact/format.rs:query.artifact.index_verify,query.artifact.ngram.page_digest,query.artifact.finalization.receipt_absorb,query.artifact.open.receipt_decode, sampledquery.artifact.ngram.encode_shard/decode_shardretrieval/lexical/projection/artifact/postings.rs:query.artifact.ngram.project_query, sampledquery.artifact.ngram.project_documentretrieval/lexical/projection/postings.rs:query.artifact.ngram.candidate_documents,query.lane.fuzzy.build_index,query.lane.fuzzy.terms_at_distance, sampledquery.artifact.ngram.insert_documentretrieval/ports.rs:query.lane.checkpoint_digest(covers every lane's checkpoint), sampledquery.lane.bind_evidencecode_search.rs:query.code_search.map_fallback_coveragespan plusquery.code_search.degraded_total/unavailable_totalgauges on the progressive-degradation gateMixed-file leftovers (missing measures only)
exact.rs:query.lane.exact.parse_literals,query.lane.exact.enforce_batch, sampledquery.lane.exact.readmit_rowaround the per-candidate central-authority re-admissionsemantic.rs:query.lane.semantic.ann_rescore,exact_flat,assemble, and anembed_querymeasure block around the port callfusion.rs:query.fusion.compact_lane,admit_lanes,attach_decisions,query.stream.digest_set,build_cursor,verify_cursorartifact/builder.rs:query.artifact.create.schema,query.artifact.finalization.source_chain_verifyartifact/reader.rs:query.lane.lexical.select_documents,load_stats,query.lane.exact.select_documents,query.lane.fuzzy.load_vocabularyVerification
cargo check -p tracedecay-query(feature off) — cleancargo check -p tracedecay-query --features hotpath— cleancargo clippy -p tracedecay-query --all-targetswith and without--features hotpath— no warnings in this crate (only the pre-existingtracedecay-graph-dbtoo-many-arguments warning)cargo test -p tracedecay-query— 311 passed, 0 failed--no-default-features --features production,hotpath) and ran it withHOTPATH_OUTPUT_PATH: the newquery.artifact.prepare_pagespan lands in the top-15 timing table (193 calls); remaining spans are recorded but below the table's entry capcommitlint(the--from origin/masterrange also flags a pre-existing base-branch commit, unrelated to this change)Do not merge #707 as part of this PR; this branch only stacks instrumentation on top of it.