Remove the deprecated positional send_command() overload - #125
Merged
Merged
Conversation
The positional ControllerRole::send_command(cmd, volume, mute) overload was deprecated in favor of the ClientCommandControllerObject form, which can also carry seek parameters. Its deprecation notice scheduled removal for v0.8.0, the next release. Drops the declaration, the definition, and the migration note in the integration guide. No in-tree callers remain.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Removes the deprecated positional ControllerRole::send_command() overload and its obsolete migration documentation.
Changes:
- Removes the public declaration and implementation.
- Removes the integration-guide migration note.
- Confirms in-tree callers use the struct-based API.
File summaries
| File | Description |
|---|---|
include/sendspin/controller_role.h |
Removes the deprecated overload declaration. |
src/controller_role.cpp |
Removes the overload implementation. |
docs/integration-guide.md |
Removes the obsolete migration note. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControllerRole::send_command(SendspinControllerCommand, std::optional<uint8_t>, std::optional<bool>)was deprecated in favor of theClientCommandControllerObjectform, which can also carry seek parameters. The deprecation notice scheduled removal for v0.8.0, which is the next release, so this removes it.include/sendspin/controller_role.hand the definition fromsrc/controller_role.cppdocs/integration-guide.mdNo in-tree callers remain (examples and tests already use the struct form). 149/149 host tests pass.
SendspinClient::start_server()is the only other deprecated symbol; its notice targets v0.9.0, so it is left in place.