Replace the E2E suite cross product with Maestro tags in CI - #557
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Replace the E2E suite cross product with Maestro tags in CI#557kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This was referenced Jul 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 3, 2026 12:12
9fb7cc3 to
f6b1c17
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
2 times, most recently
from
August 3, 2026 14:42
05b95c0 to
b63d34b
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 3, 2026 14:42
f6b1c17 to
7fe2c6b
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 4, 2026 17:04
7fe2c6b to
c92b49f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 4, 2026 17:04
b63d34b to
275339e
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:06
275339e to
69fc2dd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 11:06
c92b49f to
06f0462
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:35
69fc2dd to
f2eaf34
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 11:35
06f0462 to
9df32cf
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:45
f2eaf34 to
1d37a2f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 11:45
9df32cf to
2d277f3
Compare
Every BrowserStack run now executes the whole e2e/tests folder and tags decide what runs inside it. Adding a test file adds no matrix rows: it only needs a tag the matrix already includes. That removes the suites x applications cross product, which grew four rows per new test. matrix.yml gains tests_path and a top-level tags block holding the default include and exclude lists. An application may override either list to adopt a test before the other three carry it. Deliberate deviation from the plan: the plan said add E2E_CONTROL_LINK per application in matrix.yml. The library derives it as "<app_id>://e2e" instead, because the deep link scheme equals the app id on all four targets. A second copy would drift from app_id. A test pins the derivation for every row. Validation rejects an include tag no test carries. Without it a typo produced a green run that executed nothing. declared_tags reads the flow headers, so both the top-level and per-application lists are checked. Also fixes three real defects found while wiring this up: - RN Android could not receive the control link at all. Its manifest restricted the custom scheme to host "cart" while the contract uses host "e2e". Host "cart" was referenced nowhere else. - The parser tests on all three platforms pinned com.shopify.checkout_kit_android_demo, which no app uses. The Kotlin sample's applicationId is com.shopify.checkoutkit.androiddemo. They now pin the four real schemes plus one unknown scheme as an explicit robustness case. - CI and local runs disagreed on variable names. Both now use E2E_APP_ID, E2E_READY_MARKER and E2E_CONTROL_LINK, and the bootstrap flow composes /cart?... from E2E_CONTROL_LINK itself. The APP_ID and CART_BOOTSTRAP_BASE_LINK bridge variables are gone. The run result payload carries include_tags and exclude_tags so a run that selected nothing is visible in the artifact instead of silently green. Verified: 163 Ruby tests, 29 Swift, 28 Kotlin, 203 jest, dev check all 12 green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 12:33
2d277f3 to
7f3e78b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 12:33
1d37a2f to
03493a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.