build(rn): lint every Swift file in the integration app - #573
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Conversation
Package Size
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
marked this pull request as draft
August 5, 2026 09:35
kieran-osgood-shopify
force-pushed
the
rn-lint-integration-app-tests
branch
from
August 5, 2026 09:38
2b346fa to
9e56383
Compare
kieran-osgood-shopify
changed the base branch from
main
to
kieran-osgood/swift-web-content-process-terminated
August 5, 2026 09:38
`lint_swift` named three files by hand, so the other test targets went unlinted. Point `SWIFT_PATHS` at the two directories instead, then fix the violations that surface. Delete `CheckoutDidFailTests.swift`. It holds an empty class and a TODO that promises to restore five tests. Those tests asserted a `__typename` discriminator on the error payload, and the wire format dropped it, so `EventSerializationTests` now asserts the field is absent. The payload coverage already moved to `ShopifyEventSerialization`, which those tests reach directly instead of through a mock event emitter. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift-web-content-process-terminated
branch
from
August 5, 2026 10:42
67f7d99 to
85ef62f
Compare
kieran-osgood-shopify
force-pushed
the
rn-lint-integration-app-tests
branch
from
August 5, 2026 10:42
9e56383 to
e1506d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
lint_swiftnamed three files by hand, so the other Swift files in the integration app went unlinted. PointSWIFT_PATHSat the two directories instead, then fix the violations that surface.Delete
CheckoutDidFailTests.swift. It holds an empty class and aTODOthat promises to restore five tests. Those tests asserted a__typenamediscriminator on the error payload, and the wire format dropped it —EventSerializationTestsnow asserts the field is absent. The payload coverage already moved toShopifyEventSerialization, which those tests reach directly instead of through a mock event emitter.The remaining diff is SwiftFormat output on four test files.
How to test
Reports 0 violations in 12 files.
🤖 Generated with Claude Code