Skip to content

build(rn): lint every Swift file in the integration app - #573

Draft
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/swift-web-content-process-terminatedfrom
rn-lint-integration-app-tests
Draft

build(rn): lint every Swift file in the integration app#573
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/swift-web-content-process-terminatedfrom
rn-lint-integration-app-tests

Conversation

@kieran-osgood-shopify

Copy link
Copy Markdown
Contributor

What changes are you making?

lint_swift named three files by hand, so the other Swift files in the integration app went unlinted. Point SWIFT_PATHS at the two directories instead, then fix the violations that surface.

Delete CheckoutDidFailTests.swift. It holds an empty class and a TODO that promises to restore five tests. Those tests asserted a __typename discriminator on the error payload, and the wire format dropped it — EventSerializationTests now asserts the field is absent. The payload coverage already moved to ShopifyEventSerialization, which those tests reach directly instead of through a mock event emitter.

The remaining diff is SwiftFormat output on four test files.

How to test

cd platforms/react-native && ./scripts/lint_swift

Reports 0 violations in 12 files.


🤖 Generated with Claude Code

@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner August 5, 2026 09:11
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
React Native npm tarball 103.1 KiB 103.1 KiB 0 B
React Native file breakdown
File Base Head Delta
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts 85.4 KiB 85.4 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts 53.0 KiB 53.0 KiB 0 B
ios/ShopifyCheckoutKit.swift 15.0 KiB 15.0 KiB 0 B
ios/AcceleratedCheckoutButtons.swift 14.0 KiB 14.0 KiB 0 B
lib/commonjs/index.js 13.1 KiB 13.1 KiB 0 B
src/components/AcceleratedCheckoutButtons.tsx 12.9 KiB 12.9 KiB 0 B
src/index.ts 12.5 KiB 12.5 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js 11.4 KiB 11.4 KiB 0 B
android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java 11.1 KiB 11.1 KiB 0 B
lib/module/index.js 10.4 KiB 10.4 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js.map 10.3 KiB 10.3 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js 10.2 KiB 10.2 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts 9.5 KiB 9.5 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js.map 9.1 KiB 9.1 KiB 0 B
src/index.d.ts 8.9 KiB 8.9 KiB 0 B
lib/module/index.js.map 8.2 KiB 8.2 KiB 0 B
src/present-dispatcher.ts 8.0 KiB 8.0 KiB 0 B
lib/commonjs/index.js.map 7.7 KiB 7.7 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.d.ts 7.6 KiB 7.6 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts 7.2 KiB 7.2 KiB 0 B
…and 110 smaller files

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 5, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml react-native ios latest iPhone 15
iOS 27 Beta
tests/shared/launch-smoke.yaml react-native android latest Google Pixel 9
Android 17.0

@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as draft August 5, 2026 09:35
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the rn-lint-integration-app-tests branch from 2b346fa to 9e56383 Compare August 5, 2026 09:38
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from main to kieran-osgood/swift-web-content-process-terminated August 5, 2026 09:38
`lint_swift` named three files by hand, so the other test targets went
unlinted. Point `SWIFT_PATHS` at the two directories instead, then fix the
violations that surface.

Delete `CheckoutDidFailTests.swift`. It holds an empty class and a TODO that
promises to restore five tests. Those tests asserted a `__typename`
discriminator on the error payload, and the wire format dropped it, so
`EventSerializationTests` now asserts the field is absent. The payload
coverage already moved to `ShopifyEventSerialization`, which those tests
reach directly instead of through a mock event emitter.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/swift-web-content-process-terminated branch from 67f7d99 to 85ef62f Compare August 5, 2026 10:42
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the rn-lint-integration-app-tests branch from 9e56383 to e1506d6 Compare August 5, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant