test(rn): assert Android error code parity with errors.ts - #576
Draft
Conversation
Package Size
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
marked this pull request as draft
August 5, 2026 09:35
…ative enum Name the single supported platform on `webViewNotSupported`, because Android System WebView can lack `WebMessageListener` and iOS never sends the code. Every other member arrives from both platforms. Add a Kotlin parity test that fails when the native enum gains a code that `src/errors.ts` does not declare. Declare `src/errors.ts` as a test input, so Gradle does not report a stale pass after that file changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-16-featupdatereact-nativetousenewnativecolorschemeproperties
branch
from
August 5, 2026 09:52
80eb817 to
f6e022b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rn-error-code-docs-and-parity
branch
from
August 5, 2026 09:52
9d3a9a1 to
3a69f5b
Compare
This was referenced Aug 5, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
errors.tscarried no documentation, so the API report listed every member as// (undocumented). Add a doc comment to each one, and markwebViewNotSupportedas Android only — Android System WebView updates apart from the operating system and can lackWebMessageListener, and iOS reports no equivalent.Add
CheckoutErrorCodeParityTest. It enumeratesCheckoutErrorCodefrom the published Android artifact and asserts each code appears insrc/errors.ts.errors.tsis hand-maintained and silently coerces an unlisted native code tounknown, so nothing caught a missing member before.Declare
../src/errors.tsas aTesttask input inandroid/build.gradle. Without it Gradle reportstestDebugUnitTest UP-TO-DATEand the test passes on stale state.How to test
Red first: delete a member from
errors.tsand confirm the test names the missing code.Stacked on #484.
🤖 Generated with Claude Code