prevent nil pointer dereference on script execution error - #456
Open
mateeaaa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a runtime panic (
nil pointer dereference) that occurs instartScriptInBackgroundwhen a configured custom script fails to execute due to an operating system or path error rather than returning a standard process exit code.Root Cause Analysis
In
control_server.go, the background goroutine executes custom scripts viaexec.Command(...)and handles errors returned bycmd.CombinedOutput().When
cmd.CombinedOutput()returns an error that is not an*exec.ExitError(for instance,os.ErrNotExist/exec.ErrNotFoundif the binary does not exist on$PATH, or anos.PathErrordue to permission issues):errors.As(err, &exitError)evaluates tofalse.exitErrorpointer remainsnil.elseblock,exitError.ExitCode()is called to populate the structured log fields.nilpointer receiver causes an unhandled runtime panic (invalid memory address or nil pointer dereference), which terminates the entire application process.Solution
Replace the call to
exitError.ExitCode()withdefaultExitCodein theelseblock logging payload. The variabledefaultExitCodeis already defined and set to1right above the branch.Changes Made
control_server.goat line 501: passdefaultExitCodeinstead ofexitError.ExitCode()when logging errors for non-ExitError failures.