Improve MiniOxygen debugger connections - #3883
Merged
Merged
Conversation
Bind the public inspector to loopback and validate Host and Origin headers so network peers and untrusted browser pages cannot attach to workerd. Add lifecycle handling and real CDP coverage to preserve supported local debugger flows. Co-authored-by: Codex <codex@openai.com>
Return explicit reconnect and close methods so the connector lifecycle is clear at call sites instead of attaching cleanup behavior to a callable function. Update the return documentation to match the object API. Co-authored-by: Codex <codex@openai.com>
Keep the release note focused on improved local debugger connections and scope the explicit patch declaration to MiniOxygen. Co-authored-by: Codex <codex@openai.com>
Give the CLI's IPv4 loopback instructions their own release note so the direct CLI change is described separately from MiniOxygen runtime behavior. Co-authored-by: Codex <codex@openai.com>
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Keep an error listener while closing a still-connecting inspector socket so its asynchronous close error does not escape during MiniOxygen disposal under parallel test load. Co-authored-by: Codex <codex@openai.com>
karreiro
approved these changes
Jul 28, 2026
aswamy
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Improve the reliability of local debugger connections to MiniOxygen.
WHAT is this pull request doing?
Uses the IPv4 loopback address consistently, clarifies the inspector connector lifecycle, and adds debugger connection coverage.
HOW to test your changes?
pnpm --filter @shopify/mini-oxygen test