Skip dynamic constant namespaces in class definitions - #471
Merged
rafaelfranca merged 1 commit intoAug 26, 2026
Merged
Conversation
rafaelfranca
force-pushed
the
fix/skip-dynamic-namespace-in-class-defs
branch
from
August 26, 2026 01:18
b0d0d68 to
32d8f28
Compare
rafaelfranca
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402
Packwerk crashed with TypeError when a class used a dynamic namespace such as module_parent::Base. The inspector already skipped that pattern for ordinary constant lookups. The class definition path did not.
This change treats both paths the same. Packwerk skips the reference instead of aborting the run.
Tests cover a dynamic superclass and a dynamic class name.