Fix writing out and testing Concentration. - #642
Open
ktbolt wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 73.14% 73.11% -0.04%
==========================================
Files 259 259
Lines 39516 39515 -1
Branches 6673 6674 +1
==========================================
- Hits 28904 28891 -13
- Misses 10368 10381 +13
+ Partials 244 243 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kko27
approved these changes
Sep 9, 2026
kko27
left a comment
Contributor
There was a problem hiding this comment.
Approved! I did have two comments.
- Is there documentation for setting up simulations that involve scalar transport? I did not realize that there was a nuance of creating an Alias output type (to rename temperature as concentration).
- Where does the reference solution for this test case come from?
Collaborator
Author
|
@kko27 There is some basic documentation for the The reference solution is from rerunning the simulation with the updated solver.xml file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes writing Concentration data and updates the CI test to check those results. #638.