Skip to content

Fix writing out and testing Concentration. - #642

Open
ktbolt wants to merge 1 commit into
SimVascular:mainfrom
ktbolt:dye_AD-does-not-output-Concentration_638
Open

Fix writing out and testing Concentration.#642
ktbolt wants to merge 1 commit into
SimVascular:mainfrom
ktbolt:dye_AD-does-not-output-Concentration_638

Conversation

@ktbolt

@ktbolt ktbolt commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

This fixes writing Concentration data and updates the CI test to check those results. #638.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ktbolt
ktbolt requested review from dseyler and kko27 September 9, 2026 01:06
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.11%. Comparing base (2148c18) to head (41bc0e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   73.14%   73.11%   -0.04%     
==========================================
  Files         259      259              
  Lines       39516    39515       -1     
  Branches     6673     6674       +1     
==========================================
- Hits        28904    28891      -13     
- Misses      10368    10381      +13     
+ Partials      244      243       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kko27 kko27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! I did have two comments.

  1. Is there documentation for setting up simulations that involve scalar transport? I did not realize that there was a nuance of creating an Alias output type (to rename temperature as concentration).
  2. Where does the reference solution for this test case come from?

@ktbolt

ktbolt commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

@kko27 There is some basic documentation for the Precomputed_solution parameter but it does not really explain the scalar transport usage well enough. I think we will add a User Guide section for this.

The reference solution is from rerunning the simulation with the updated solver.xml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants