Skip to content

Fix error in lumen_inlet.flow files. - #644

Open
ktbolt wants to merge 3 commits into
SimVascular:mainfrom
ktbolt:Error-lumen_inlet-flow-data_643
Open

Fix error in lumen_inlet.flow files.#644
ktbolt wants to merge 3 commits into
SimVascular:mainfrom
ktbolt:Error-lumen_inlet-flow-data_643

Conversation

@ktbolt

@ktbolt ktbolt commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

This fixes an error at line 10

0.250000,-6.283185

in several tests/cases/fluid lumen_inlet.flow files used in CI tests. #643

CI test results files don't need to be updated because the test simulations are run for a single time step with dt=0.001.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ktbolt

ktbolt commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Note that several of the fluid simulations use the same mesh and inlet flow file so I am wondering if we should create a common data directory to store shared data.

@alisonmarsden

Copy link
Copy Markdown

I think we need a suite of "full scale" test cases that get run periodically, in addition to the ones used in the CI when merging in new changes. I believe this is common practice in other settings for solver development (e.g. HeartFlow). For example, these should full scale (reasonable mesh, unsteady) CFD simulations where we've got experimental data or analytic solutions to compare agains (we can generate more of these). Running for a couple of time steps only is insufficient for full testing. This suite could be run once a month, for example.....

@ktbolt

ktbolt commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

@alisonmarsden Adding full-scale simulations is in the works; this will included validation cases.

@alisonmarsden

Copy link
Copy Markdown

Perfect. We have some validation data available from the Ennis lab we can also start incorporating (flow through tubes, bends, stenoses) with 4DFlow experimental data. Agree these should live in a common folder.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.45%. Comparing base (00f5c92) to head (99ca585).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         267      267           
  Lines       40041    40041           
  Branches     6706     6706           
=======================================
  Hits        29413    29413           
  Misses      10385    10385           
  Partials      243      243           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javijv4 javijv4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants