Fix error in lumen_inlet.flow files. - #644
Conversation
|
Note that several of the fluid simulations use the same mesh and inlet flow file so I am wondering if we should create a common data directory to store shared data. |
|
I think we need a suite of "full scale" test cases that get run periodically, in addition to the ones used in the CI when merging in new changes. I believe this is common practice in other settings for solver development (e.g. HeartFlow). For example, these should full scale (reasonable mesh, unsteady) CFD simulations where we've got experimental data or analytic solutions to compare agains (we can generate more of these). Running for a couple of time steps only is insufficient for full testing. This suite could be run once a month, for example..... |
|
@alisonmarsden Adding full-scale simulations is in the works; this will included validation cases. |
|
Perfect. We have some validation data available from the Ennis lab we can also start incorporating (flow through tubes, bends, stenoses) with 4DFlow experimental data. Agree these should live in a common folder. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 267 267
Lines 40041 40041
Branches 6706 6706
=======================================
Hits 29413 29413
Misses 10385 10385
Partials 243 243 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This fixes an error at line 10
in several
tests/cases/fluidlumen_inlet.flow files used in CI tests. #643CI test results files don't need to be updated because the test simulations are run for a single time step with dt=0.001.