Fix changed-file detection for renamed extension description files - #2382
Merged
Merged
Conversation
The AI analysis workflow collected changed files with --diff-filter=AM, which silently dropped files that git classifies as renamed (R), e.g. when an extension description file is renamed with small edits. The analysis then ran with no input while the job still reported success. Include renames (--diff-filter=AMR) in both the AI analysis and the extension validation workflows (--name-only reports a renamed file under its new path), exclude deletions from the validation file list, and emit a workflow warning when the AI analysis file list is empty so this failure mode is visible on the run page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI analysis workflow collected changed files with --diff-filter=AM, which silently dropped files that git classifies as renamed (R), e.g. when an extension description file is renamed with small edits. The analysis then ran with no input while the job still reported success.
Include renames (--diff-filter=AMR) in both the AI analysis and the extension validation workflows (--name-only reports a renamed file under its new path), exclude deletions from the validation file list, and emit a workflow warning when the AI analysis file list is empty so this failure mode is visible on the run page.