Skip to content

Fix packaging test skipped for renamed extension description files - #2383

Merged
lassoan merged 1 commit into
Slicer:mainfrom
lassoan:fix-package-workflow-rename-filter
Aug 15, 2026
Merged

lassoan merged 1 commit into
Slicer:mainfrom
lassoan:fix-package-workflow-rename-filter

Conversation

@lassoan

@lassoan lassoan commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

The Package Python Extension workflow collected changed files with --diff-filter=AM, which drops files that git classifies as renamed (R). When an extension description file was renamed, find-extensions reported no extensions and the packaging test was silently skipped.

Include renames (--diff-filter=AMR), matching the fix already applied to the extension validation and AI analysis workflows. --name-only reports a renamed file under its new path.

The Package Python Extension workflow collected changed files with
--diff-filter=AM, which drops files that git classifies as renamed (R).
When an extension description file was renamed, find-extensions
reported no extensions and the packaging test was silently skipped.

Include renames (--diff-filter=AMR), matching the fix already applied
to the extension validation and AI analysis workflows. --name-only
reports a renamed file under its new path.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lassoan
lassoan merged commit f7b31fd into Slicer:main Aug 15, 2026
5 checks passed
@lassoan
lassoan deleted the fix-package-workflow-rename-filter branch August 15, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant