WWSTCERT-11943 Added support for Bosch Motion Detector II [+M] by JanJakubiszyn · Pull Request #2555 · SmartThingsCommunity/SmartThingsEdgeDrivers

JanJakubiszyn · 2025-11-14T15:59:36Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - [x ] I have reviewed the README.md file
  - [ x] I have reviewed the CODE_OF_CONDUCT.md file
  - [ x] I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
[ x] Refactor

Checklist

[ x] I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2025-11-14T16:00:02Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-11-14T16:00:45Z

Channel deleted.

github-actions · 2025-11-14T16:02:25Z

Test Results

73 files ±0 515 suites ±0 0s ⏱️ ±0s
2 904 tests ±0 2 904 ✅ +1 0 💤 ±0 0 ❌ - 1
4 800 runs ±0 4 800 ✅ +1 0 💤 ±0 0 ❌ - 1

Results for commit f131705. ± Comparison against base commit 42a6a23.

♻️ This comment has been updated with latest results.

github-actions · 2025-11-14T16:02:27Z

File	Coverage
All files	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/embedded_cluster_utils.lua	`38%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua	`87%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_handlers/event_handlers.lua	`93%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against f131705

hcarter-775 · 2025-11-25T18:25:30Z

Has this been tested on-device?

JanJakubiszyn · 2025-11-27T15:05:56Z

Has this been tested on-device?

Yes, I have tested it with the device and it works well.

I have implemented all of the mentioned changes from the review.

Thank You!

greens · 2025-12-05T19:54:49Z

@JanJakubiszyn You'll need to rebase your changes.

JanJakubiszyn · 2025-12-08T13:24:33Z

@JanJakubiszyn You'll need to rebase your changes.

All done.

JanJakubiszyn · 2025-12-19T16:27:20Z

Hi @hcarter-775, @greens,

To fix the an issue with default 70% dim value after sending the "on" command I have added the "OnLevel" attribute change (WWST-10126)
I also added refresh after the info_changed function is triggered. It has been done to increase the speed of the temperature update after temperature_offset preference is changed.

Please let me know if I should proceed with editing the rest of the unit tests accordingly or should I take a different approach.

greens · 2026-01-16T19:30:44Z

Looks like this has fallen out of date again

greens · 2026-01-22T22:54:06Z

Your changes seem to have led to tests failing.

JanJakubiszyn · 2026-01-26T12:40:14Z

Your changes seem to have led to tests failing.

Hi @greens , I've fixed the failing test.

hcarter-775

other than these last edge-case nits, this lgtm. Thanks for the prompt responses!

JanJakubiszyn · 2026-01-27T16:50:34Z

@hcarter-775, I've applied your suggestions. Thanks!

hcarter-775 · 2026-01-27T17:04:30Z

@JanJakubiszyn sweet, this lgtm. Now we just have to fix the unit tests that have broken (probably due to the extra preference gating you introduced?)

JanJakubiszyn · 2026-01-27T17:29:55Z

@JanJakubiszyn sweet, this lgtm. Now we just have to fix the unit tests that have broken (probably due to the extra preference gating you introduced?)

Done. Everything should be good now.

hcarter-775 · 2026-01-27T19:30:37Z

Hey @JanJakubiszyn , can you pull the preference stuff you've added into a separate PR? Then we can push that forward this week without the WWST stuff. cc: @nickolas-deboom

# Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua # drivers/SmartThings/matter-switch/src/switch_utils/fields.lua

… name and capability order, edit of the match_profile's condition # Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua # Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua

JanJakubiszyn · 2026-01-28T13:40:51Z

Hey @JanJakubiszyn , can you pull the preference stuff you've added into a separate PR? Then we can push that forward this week without the WWST stuff. cc: @nickolas-deboom

Hi @hcarter-775, I have transferred the offset reading to another PR - #2737

cbaumler · 2026-06-05T15:30:57Z

Hi @JanJakubiszyn, it looks like this PR branch is out of date with main. Could you update it with the latest main? Then @hcarter-775 can re-review.

cbaumler · 2026-06-09T14:56:38Z

Hi @JanJakubiszyn, it looks like there are test failures being reported by CI.

hcarter-775 · 2026-06-10T17:21:51Z

+      - id: switch
+        version: 1
+      - id: switchLevel
+        version: 1
+        config:
+          values:
+            - key: "level.value"
+              range: [1, 100]


To keep profile consistency, these should be the first two listed capabilities.

The third should be one that is currently unlisted, i.e.

- id: statelessSwitchLevelStep version: 1

@hcarter-775 device profile re-arranged

hcarter-775 · 2026-06-10T17:22:13Z

+      - name: MotionSensor
+preferences:
+  - preferenceId: tempOffset
+    explicit: true


add newline

hcarter-775

LGTM

KKlimczukS requested review from greens and hcarter-775 November 18, 2025 08:36

greens changed the title ~~Added support for Bosch matter motion sensor~~ WWSTCERT-9109 Added support for Bosch matter motion sensor Nov 24, 2025

greens requested a review from nickolas-deboom November 24, 2025 19:53

hcarter-775 reviewed Nov 25, 2025

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/profiles/light-level-motion-illuminance-battery-temp.yml Outdated

hcarter-775 reviewed Nov 25, 2025

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua Outdated

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from f1676a1 to 0723d13 Compare November 27, 2025 15:03

KKlimczukS requested a review from hcarter-775 December 3, 2025 10:30

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from 6ca7abe to 23045f1 Compare December 8, 2025 13:02

hcarter-775 approved these changes Dec 8, 2025

View reviewed changes

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from 0b18bd6 to 98408c7 Compare December 19, 2025 15:30

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from 352509c to a7599b5 Compare January 22, 2026 15:37

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from a7599b5 to a7615c3 Compare January 26, 2026 12:36

hcarter-775 reviewed Jan 26, 2026

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua Outdated

hcarter-775 reviewed Jan 26, 2026

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/src/init.lua Outdated

hcarter-775 reviewed Jan 26, 2026

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/src/init.lua Outdated

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch 2 times, most recently from 27e7e25 to aaf0609 Compare January 27, 2026 15:43

hcarter-775 reviewed Jan 27, 2026

View reviewed changes

Comment thread drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua Outdated

Comment thread drivers/SmartThings/matter-switch/src/init.lua Outdated

Comment thread drivers/SmartThings/matter-switch/src/init.lua Outdated

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch 2 times, most recently from 78cf6fe to 5bcda22 Compare January 27, 2026 17:25

JanJakubiszyn added 3 commits January 28, 2026 13:09

Added support for Bosch matter motion sensor

f22f187

# Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua # drivers/SmartThings/matter-switch/src/switch_utils/fields.lua

Code cleanup

90ed999

JanJakubiszyn force-pushed the Bosch_motion_sensor_support branch from 5bcda22 to 90ed999 Compare January 28, 2026 13:38

KKlimczukS changed the title ~~WWSTCERT-9109 Added support for Bosch matter motion sensor~~ WWSTCERT-11925 Added support for Bosch Motion Detector II [+M] May 26, 2026

Update fingerprints.yml

b4614d1

KKlimczukS changed the title ~~WWSTCERT-11925 Added support for Bosch Motion Detector II [+M]~~ WWSTCERT-11943 Added support for Bosch Motion Detector II [+M] May 27, 2026

KKlimczukS requested review from cbaumler and hcarter-775 and removed request for greens May 27, 2026 08:07

Merge branch 'main' into Bosch_motion_sensor_support

86d63ce

cbaumler requested a review from ctowns May 27, 2026 16:17

Merge branch 'main' into Bosch_motion_sensor_support

d1b2016

Merge branch 'main' into Bosch_motion_sensor_support

71a4c0c

hcarter-775 reviewed Jun 10, 2026

View reviewed changes

Update light-level-battery-illuminance-motion-temperature.yml

f131705

KKlimczukS requested a review from hcarter-775 June 11, 2026 08:45

hcarter-775 approved these changes Jun 11, 2026

View reviewed changes

KKlimczukS merged commit 614a284 into SmartThingsCommunity:main Jun 12, 2026
14 of 17 checks passed

Conversation

JanJakubiszyn commented Nov 14, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hcarter-775 commented Nov 25, 2025

Uh oh!

JanJakubiszyn commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greens commented Dec 5, 2025

Uh oh!

JanJakubiszyn commented Dec 8, 2025

Uh oh!

JanJakubiszyn commented Dec 19, 2025

Uh oh!

greens commented Jan 16, 2026

Uh oh!

greens commented Jan 22, 2026

Uh oh!

JanJakubiszyn commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hcarter-775 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanJakubiszyn commented Jan 27, 2026

Uh oh!

hcarter-775 commented Jan 27, 2026

Uh oh!

JanJakubiszyn commented Jan 27, 2026

Uh oh!

hcarter-775 commented Jan 27, 2026

Uh oh!

JanJakubiszyn commented Jan 28, 2026

Uh oh!

cbaumler commented Jun 5, 2026

Uh oh!

cbaumler commented Jun 9, 2026

Uh oh!

hcarter-775 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

KKlimczukS Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

hcarter-775 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

KKlimczukS Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

hcarter-775 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

github-actions Bot commented Nov 14, 2025 •

edited

Loading

github-actions Bot commented Nov 14, 2025 •

edited

Loading

github-actions Bot commented Nov 14, 2025 •

edited

Loading

github-actions Bot commented Nov 14, 2025 •

edited

Loading

JanJakubiszyn commented Nov 27, 2025 •

edited

Loading