Support additional Camera device types#2590
Open
nickolas-deboom wants to merge 2 commits into
Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 73 files 515 suites 0s ⏱️ Results for commit afca26f. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against afca26f |
samadDotDev
approved these changes
Feb 10, 2026
samadDotDev
left a comment
samadDotDev
left a comment
Contributor
There was a problem hiding this comment.
Will need to re-evaluate after rebase
hcarter-775
reviewed
Feb 10, 2026
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
from
96ccae6 to
67332b9
Compare
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
2 times, most recently
from
e012e2a to
a25f0c7
Compare
hcarter-775
reviewed
Mar 3, 2026
hcarter-775
reviewed
Mar 3, 2026
hcarter-775
reviewed
Mar 3, 2026
hcarter-775
reviewed
Mar 3, 2026
hcarter-775
reviewed
Mar 3, 2026
nickolas-deboom
commented
Mar 5, 2026
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
2 times, most recently
from
31bd85e to
164095f
Compare
samadDotDev
approved these changes
Mar 5, 2026
samadDotDev
reviewed
Mar 6, 2026
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
2 times, most recently
from
b1faa74 to
297c2e3
Compare
hcarter-775
reviewed
Mar 9, 2026
hcarter-775
reviewed
Mar 9, 2026
hcarter-775
reviewed
Mar 9, 2026
hcarter-775
reviewed
Mar 9, 2026
hcarter-775
reviewed
Mar 9, 2026
samadDotDev
reviewed
Mar 10, 2026
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
2 times, most recently
from
63e0a39 to
17d5bb3
Compare
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
from
a19ba8c to
0080716
Compare
ctowns
reviewed
Jun 3, 2026
ctowns
reviewed
Jun 3, 2026
| --- @param subscribed_events table key-value pairs mapping capability ids to subscribed events | ||
| function utils.populate_subscribe_request_for_device(checked_device, subscribe_request, capabilities_seen, attributes_seen, events_seen, subscribed_attributes, subscribed_events) | ||
| for _, component in pairs(checked_device.st_store.profile.components) do | ||
| function utils.populate_subscribe_request_for_device(checked_device, parent_device, subscribe_request, capabilities_seen, attributes_seen, events_seen, subscribed_attributes, subscribed_events) |
Contributor
There was a problem hiding this comment.
Could we just update this function to get the parent device of the checked_device as needed rather than passing on the parent device in the function parameters? If the device doesn't have a parent device, then we would know that it is the parent device.
Contributor
Author
There was a problem hiding this comment.
Good idea, changed in afca26f as suggested
ctowns
reviewed
Jun 3, 2026
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
from
0080716 to
394d80d
Compare
ctowns
reviewed
Jun 8, 2026
This adds support for the following device types: * 0x0140 Intercom * 0x0141 Audio Doorbell * 0x0142 Camera * 0x0143 Video Doorbell * 0x0144 Floodlight Camera * 0x0145 Snapshot Camera * 0x0146 Chime * 0x0148 DoorBell
nickolas-deboom
force-pushed
the
support-additional-camera-device-types
branch
from
42bfb6a to
054364c
Compare
ctowns
approved these changes
Jun 11, 2026
ctowns
left a comment
ctowns
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good to me, thanks for making those changes @nickolas-deboom !
Before merging, is there any testing that can be documented in the top comment of the PR? Even if we don't have any of these devices yet, it might be good to run a quick regression test on an existing camera device just to make sure things still work since the init logic is being changed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the following device types: