Add removed connection checkstyle rule - #86
Merged
Conversation
sfc-gh-pvillard
force-pushed
the
agent/wi133-removed-connection-rule
branch
from
August 7, 2026 10:48
9b57221 to
e39dd50
Compare
sfc-gh-dchaffelson
approved these changes
Aug 7, 2026
sfc-gh-dchaffelson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — clean, backward-compatible feature with genuinely thorough test coverage (nested/deleted process groups, UUID-identity semantics incl. delete-and-redraw, null-previous first-version safety, and all three exclusion levels). The 3-arg getCheckstyleViolations overload keeps existing callers untouched, and the null-previous guard in RemovedConnectionRule is correct.
One non-blocking question: removedConnection is registered as a default rule, so it'll fire for all existing default-checkstyle consumers whenever a connection is legitimately removed. Assuming on-by-default (with exclude as the opt-out) is the intended UX rather than opt-in — just flagging in case you'd want it opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removedConnectioncheckstyle rule that reports connection UUIDs removed between flow versionsTest plan
mvn -f flow-diff/pom.xml test(64 tests)git diff origin/main...HEAD --check