Skip to content

Add removed connection checkstyle rule - #86

Merged
sfc-gh-pvillard merged 1 commit into
mainfrom
agent/wi133-removed-connection-rule
Aug 8, 2026
Merged

Add removed connection checkstyle rule#86
sfc-gh-pvillard merged 1 commit into
mainfrom
agent/wi133-removed-connection-rule

Conversation

@sfc-gh-pvillard

Copy link
Copy Markdown
Collaborator

Summary

  • add a default removedConnection checkstyle rule that reports connection UUIDs removed between flow versions
  • preserve existing checkstyle callers while passing the previous snapshot to rules
  • support nested/deleted process groups, component exclusions, and existing include/exclude controls
  • document the rule and add focused unit and integration coverage

Test plan

  • mvn -f flow-diff/pom.xml test (64 tests)
  • git diff origin/main...HEAD --check
  • changed Java files checked for package/import/brace issues, suppressions, conflict markers, and ticket references

@sfc-gh-pvillard
sfc-gh-pvillard force-pushed the agent/wi133-removed-connection-rule branch from 9b57221 to e39dd50 Compare August 7, 2026 10:48

@sfc-gh-dchaffelson sfc-gh-dchaffelson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean, backward-compatible feature with genuinely thorough test coverage (nested/deleted process groups, UUID-identity semantics incl. delete-and-redraw, null-previous first-version safety, and all three exclusion levels). The 3-arg getCheckstyleViolations overload keeps existing callers untouched, and the null-previous guard in RemovedConnectionRule is correct.

One non-blocking question: removedConnection is registered as a default rule, so it'll fire for all existing default-checkstyle consumers whenever a connection is legitimately removed. Assuming on-by-default (with exclude as the opt-out) is the intended UX rather than opt-in — just flagging in case you'd want it opt-in.

@sfc-gh-pvillard
sfc-gh-pvillard merged commit c1605f3 into main Aug 8, 2026
4 checks passed
@sfc-gh-pvillard
sfc-gh-pvillard deleted the agent/wi133-removed-connection-rule branch August 8, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants