780 vite update dependencies#794
Conversation
- Changed build config from webpack to vite (see details below). - Moved root files to /lib for better code organization, leaving main entry points in root. - Implemented custom customElement decorator to work around duplicated registrations. The new configuration produces the following outputs: - For npm consumers, *.esm.js and *.cjs.js files. The main export exposes helpers, all components can be registered with solid-ui/components, and individual components can be registered with solid-ui/components/*. - For modern CDNs, we have ESM bundles in *.js files, also allowing all components or invidiual imports. These now include solid-logic and rdflib, no need to load them separatedly. - For legacy CDNs, we still have the UMD bundles, but those are discouraged and not documented in the README anymore. These ones still externalize solid-logic and rdflib. References: - Lit Publishing docs: https://lit.dev/docs/tools/publishing - Web Awesome installation docs: https://webawesome.com/docs - Web Awesome discussion on CDN declarations: shoelace-style/webawesome#2146
- Changed build config from webpack to vite (see details below). - Moved root files to /lib for better code organization, leaving main entry points in root. - Implemented custom customElement decorator to work around duplicated registrations. The new configuration produces the following outputs: - For npm consumers, *.esm.js and *.cjs.js files. The main export exposes helpers, all components can be registered with solid-ui/components, and individual components can be registered with solid-ui/components/*. - For modern CDNs, we have ESM bundles in *.js files, also allowing all components or invidiual imports. These now include solid-logic and rdflib, no need to load them separatedly. - For legacy CDNs, we still have the UMD bundles, but those are discouraged and not documented in the README anymore. These ones still externalize solid-logic and rdflib. References: - Lit Publishing docs: https://lit.dev/docs/tools/publishing - Web Awesome installation docs: https://webawesome.com/docs - Web Awesome discussion on CDN declarations: shoelace-style/webawesome#2146
#780 Migrate to Vite, Vitest, and Storybook 10
|
I am not sure what to make if this PR. It is containing work from other PRs? |
|
@timea-solid Yes, it was built from my working branch in #787. The commits are displayed as new commits because I rewrote history addressing some feedback before merging the PR. I guess @bourgeoa can cherry-pick his latest commit on top of main now, or reapply the changes, etc. But the last commit in the PR is what we should be looking at. I'll wait until he resolves the conflicts before adding my review though. |
|
@NoelDeMartin |
|
@bourgeoa The rebase didn't work as expected, because you've rebased the branch with my previous commits. If you look at the PR, it says there are 14 new commits but there should only be two (or maybe one, I think I already fixed that test in #796, I guess whichever gets merged first wins xD). Instead of a rebase, you should cherry-pick or apply your changes from a clean staging checkout. If you have issues doing that let me know and we can jump on a call and I help you do it. |
3 participants
No description provided.