-
Notifications
You must be signed in to change notification settings - Fork 1
FIX BED-8687: Replace fields that use type Any with fixed types to fix DLT schema validation errors
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d3vzer0
wants to merge
16
commits into
main
Choose a base branch
from
fix/BED-8687
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−35
Open
FIX BED-8687: Replace fields that use type Any with fixed types to fix DLT schema validation errors
#14
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c7aa4f8
Fix type for WorkFLowJob runs_on field
d3vzer0 36ed53d
Fix type for WorkFLowJob runs_on field
d3vzer0 ddd04eb
Replace "Any" field types with fixed types for Workflow model fields
d3vzer0 ed087ee
Create a list of runs_on instead of single-value string.
d3vzer0 75f1a7f
Make WorkflowJobDefinition fields optional
d3vzer0 89259d3
Container can be a single-value string as well
d3vzer0 4185d2b
Simplify returning container image name
d3vzer0 83acaca
Add None as allowed value for permissions in WorkflowDocument
d3vzer0 5bcc84c
Also normalize the secrets map when loading the model
d3vzer0 39568ba
Combine secret/env normalization in single validator
d3vzer0 c6dbfda
Combine runs_on/permissions normalization in single validator
d3vzer0 ef304a6
Add additional types for runs_on
d3vzer0 da4e318
Split runs_on normalizer due to more complex field types
d3vzer0 c961e31
Remove is_self_hosted from top Workflow model
d3vzer0 93c84bf
Add is_self_hosted to sub WorkflowJob model + added safety to check i…
d3vzer0 2318a02
Add typehint
d3vzer0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.