Grant ALL APPLICATION PACKAGES read access on the app install root - #1918
Open
codebytere wants to merge 2 commits into
Open
codebytere wants to merge 2 commits into
codebytere wants to merge 2 commits into
Conversation
Restricted-token sandbox processes (Chromium, Electron, CEF children) are denied access to a directory whose ACL carries an AppContainer package ACE but no ALL APPLICATION PACKAGES entry. Per-user installs under %LocalAppData% can inherit the former from other software; Program Files installs always have the latter. Add the same inheritable read/execute grant on the app root at install time and at the start of an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps whose child processes run in a restricted-token sandbox (Chromium, Electron, CEF) fail to start from a Squirrel install when
%LocalAppData%carries an inherited ACE for some AppContainer package SID: Windows then evaluates the restricted token against the folder as if it were an AppContainer, and only anALL APPLICATION PACKAGESentry can grant access. Per-machine installs under Program Files always have that entry; per-user Squirrel installs do not, so the sandboxed processes are denied their own install directory (electron/electron#51761 has the reports and the ACL analysis).This adds an inheritable read/execute ACE for
ALL APPLICATION PACKAGES(S-1-15-2-1) on the app root during install, before files are extracted, and again at the start of an update so existing installs pick it up. Failure to set it is logged and does not fail the install.