Repository navigation
Achievements on arcade via tak.arcade (RFC 0014) - #11
Merged
Merged
Conversation
Nine achievements, reported with tak.arcade.unlock at the moment they happen: four discoveries (the count, the manifest, the old depot, the answer to the count), everything the station can tell you, the first remembered choice, and one per ending (Aksel staying is hidden). Game.learn reports a newly learned fact, Scene.remember the remembered choice, and a loaded save reports what it already earned. Nothing is written to the save. tak pinned at 963cd3c, which adds tak.arcade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0116e9DMUhtNXM5bHUdMhDAn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwinter is given nine achievements on arcade, reported through
tak.arcade.unlock(tak PR #21, Stephenson-Software RFC 0014). Since knowledge is the progression here, the achievements follow facts and endings:countedTHE_STORElearnedsigned-forTHE_MANIFESTlearnedold-storesTHE_DEPOTlearnedthe-answerTHE_FIFTHlearnedthe-whole-winterrememberedScene.remembertwentieth-morningFIVE_OUT(ending)in-the-darkTHE_DARK_FLIGHT(ending)his-choiceAKSEL_STAYED(ending)How it works:
src/overwinter/achievements.pyholds the declarations and the hooks.Game.learnreports a fact only when it is newly learned (endings are facts, learned at the moment the winter ends), andScene.rememberreports the remembered choice.achievements.catchUp), so a winter played before this change still counts. It only reads the state.963cd3c(addstak.arcade; the only change since the previous pin).overwinterin the gateway'sconfig/play/boards.yamlseparately; that snippet was checked with arcade-social's ownboards.load.Verification:
tests/test_achievements.py(10 tests) runs the existing scripted routes withtak.arcade.unlockmocked: five on the plane with everything known, Aksel staying, and the dark flight each report the expected ids, and together they cover every declared id. A new game reports nothing; loading a save reports what it earned and leaves the save unchanged. Full suite: 55 passed.https://overwinter.play.danielstephenson.devwith arcade-social mocked. A day-19 save written byorigin/maincode loaded from IndexedDB ("Load Slot 1 (Day 19, 14 known)"). Playing on to the plane postedcounted, signed-for, old-stores, the-answer, remembered, remembered, twentieth-morningto/v1/achievements/<id>, withX-Play-Client: 1and the game origin. With/v1/sessionanswering 401, no unlock POST was made. There were no page errors in either run.drafted by Claude on behalf of Daniel Stephenson
🤖 Generated with Claude Code