Repository navigation
Remember saying five to Aksel on the strip on the last page - #16
Merged
Merged
Conversation
"He's coming with us" told the player Aksel would remember it, but the five-on-the-plane page never did, and two of its Aksel paragraphs still said "He had his winter". The refusal now has its own sentence and drops that clause, and BACKED_AKSEL_STAYING is in people.REMEMBERED like every other remembered choice, so achievements no longer special-cases it. Closes #15 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 37428899792:
Repo-specific:
Notes:
This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endings._akselnow readsflags.BACKED_AKSEL_STAYING. If the player said five when Aksel asked them on the strip to say four, the five-on-the-plane page adds a sentence on what that cost him: the hut, the holes, the August ship and the last winter he had asked for. The "He had his winter" clauses are dropped in that case, because the page used to say he had his winter right after he was refused it.BACKED_AKSEL_STAYINGis added topeople.REMEMBERED, alongside every other choice that ends in "X will remember that".achievements._rememberedSomethingloses its special case, and the import it no longer needs goes with it. The flag is set on the strip and not during a conversation, soScene.talkcannot fire a second "will remember" beat.docs/STORY.mdupdates the five-on-the-plane line to mention the refusal.version.txtgoes from 0.1.0 to 0.1.1, because the change is visible to players.The save format,
state.py,schemas/save.json, the calendar and the RNG are not changed.Test plan
python3 -m pytest: 69 passed (67 before, plus 2 new)tests/test_ending_pages.py::test_saying_five_on_the_strip_is_remembered_and_takes_back_his_wintercovers all four ways Aksel can reach the table, with and without the refusaltest_the_strip_choice_is_one_people_rememberFULL_RUN(test_the_winter_can_be_finished_with_five_on_the_plane) now asserts that the refusal sentence is shown. Every solve still passes and no script changed.endings.py,people.pyandachievements.pyreverted, the 3 new or changed tests fail. With the fix restored, they pass.black --checkpasses on the changed Python filesCloses #15
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson