Skip to content

test: pin the public gameDisplay attribute on both constructor paths #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmccoystephenson merged 2 commits into from
Oct 9, 2026
Merged

test: pin the public gameDisplay attribute on both constructor paths #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22d84d
Pin the public gameDisplay attribute on both constructor paths
dmccoystephenson Oct 9, 2026
e731e01
Correct the scope claim in the gameDisplay test comment
dmccoystephenson Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/test/python/preponderous/graphik/test_graphik.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,24 @@ def test_no_arg_constructor_creates_default_display():
assert graphik.getGameDisplay().get_size() == (900, 600)


@pytest.mark.parametrize("supplied", [True, False], ids=["supplied_display", "default_display"])
def test_game_display_attribute_is_the_bound_surface(supplied):
# Consumers read the gameDisplay attribute directly rather than going
# through getGameDisplay() -- Apex sizes its layout off
# graphik.gameDisplay.get_size() -- so the attribute name is part of the
# public contract. Renaming it to something private would leave every
# other test in this file green while breaking those call sites, so pin
# it on both constructor paths.
pygame.display.init()
if supplied:
display = pygame.display.set_mode((10, 10))
graphik = Graphik(display)
assert graphik.gameDisplay is display
else:
graphik = Graphik()
assert graphik.gameDisplay is graphik.getGameDisplay()


def test_color_constants_are_reachable():
# The color constants used to be assigned only in an unreachable __init__;
# they must now be present on both the class and any instance.
Expand Down
Loading