Repository navigation
Require the program version and tag every event with it; 0.4.0 - #5
Merged
Merged
Conversation
builder(baseUrl, application, version) now takes the program's own version, required (blank or over 255 characters throws). Every event the client sends carries it as the tag `version` -- command events and any other, not only a hand-tagged startup -- so each event can be tied to a release. An event's own `version` tag wins; the program version is placed above server-wide tags, so a server-wide `version` never replaces it. The caller's tag map is never modified. Breaking: the two-argument builder is gone. Upgrading is one argument (in a Bukkit plugin, getDescription().getVersion()). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
This was referenced Sep 30, 2026
Merged
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
dmccoystephenson
added a commit
to Stephenson-Software/trace-client-cpp
that referenced
this pull request
Sep 30, 2026
* Carry the program's version on every event (0.2.0) The constructor now takes the program's own version as a required argument after the application name. It is trimmed and sent as the tag "version" on every event; an event's own "version" tag wins, and the caller's tags are never modified. A blank version, or one over 255 bytes, disables the client with reason "unavailable", matching how a blank base URL or application name is handled, since nothing in the client throws. The default-constructed (disabled) client holds the placeholder version "disabled". The User-Agent still names the client's version. Breaking change: TRACE_CLIENT_VERSION 0.1.0 -> 0.2.0. Mirrors Stephenson-Software/trace-client-java#5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji * Doc comment: the version is the constructor's third argument Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builder(baseUrl, application, version)now requires the program's own version. Every event the client sends carries it as the tagversion, includingcommandand any other event, not only a hand-taggedstartup. An event's ownversiontag wins. The version sits above the server-wide tags, so a server-wideversionnever replaces it.Breaking (0.3.0 → 0.4.0): the two-argument builder has been removed. Upgrading means passing one more argument (in a Bukkit plugin,
getDescription().getVersion()). All consumers are re-vendored in a follow-up pass.Tests:
mvn testpasses, 46/46. New tests cover a command tagged with the trimmed version, an event's own version winning, the caller's map left unmodified, and a blank/overlong version being rejected. A mutation probe that removes the injection fails 10 tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
drafted by Claude on behalf of Daniel Stephenson