Conversation
Adds a DataService for Babamul, the public service of the BOOM alert broker for ZTF and LSST alerts. Supports cone search and lookup by object id. Photometry is read from the object endpoint, which carries the full light curve: detections are stored as brightness and prv_nondetections as limits. The most recent detection appears in both candidate and prv_candidates, so detections are deduplicated by candidate id. Reduced datums are looked up on the fields covered by the model's uniqueness constraint, so that a later sync reporting a different uncertainty updates nothing rather than failing to match and raising. The API key is read from DATA_SERVICES, following the TNS pattern. Refs TOMToolkit#1405
Author
|
I have two questions:
|
The scheduled canary job runs with no secrets, so a hardcoded placeholder api_key would fail against the live API with a 401. Skip the test unless BABAMUL_API_KEY is set.
Fingel
approved these changes
Sep 10, 2026
Fingel
left a comment
Contributor
There was a problem hiding this comment.
I tested this locally. Searching by name works, ra/dec works, saving the query works and creating targets. Looks good to me!
Author
|
I was checking on this PR, and I noticed a couple of tests that ran exactly the same ingest or query and just checked different parts so I consolidated them. Also, the duplicate detection test was already covered because the detection count fails when the dedup is removed. If there's anything else I can do to help merge this PR in, happy to do so! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a DataService for Babamul, the public service of the BOOM alert broker for ZTF and LSST alerts.
Supports cone search and lookup by object id. Photometry is read from the object endpoint, which carries the full light curve: detections are stored as
brightnessandprv_nondetectionsas limits.The API key is read from DATA_SERVICES, following the TNS pattern.
Refs issue #1405