CL-32 drivers & more

[KenVanHoeylandt]

• CL-32 features added:
  • Hardware revision detection
  • v0.3 and v0.4 keyboard
  • v0.4 power supply
  • Inlined epd library (was a module) and made changes to the device definition (don't do full update after 5 small updates)
• Statusbar: add support for inverted colors
• e-paper driver improvements and warning fixes
• Implemented gpio_controller_get_level()
• Keyboard support improvements (unicode for tca drivers)

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The change adds CL32 hardware-revision detection with revision-specific keyboards and power devices. It adds an ESP-IDF e-paper component with panel registries, SPI transport, controller drivers, LVGL support, mirroring, and persistent refresh operations. TCA8418 keymaps now use 32-bit code points. Statusbar colors can be inverted through device properties and Kconfig. Platform changes update task sizing, I2C logging, module symbols, GPIO access, and device initialization fields.

Priority: ➖ Normal

Merge Risk: 🟡 Moderate · up to bebbb

E-paper devices can hang, render corrupt frames, or hide failed updates, and ESP32P4 firmware builds can fail. These should be corrected before merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 30.07% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 153 functions across 52 files. (3 skipped…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the major CL-32 driver changes. The broad “& more” also covers the additional paper-display and platform updates without making the title unrelated or misleading.

Full details: Docstring Coverage

Explanation

Docstring coverage is 30.07% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 153 functions across 52 files. (3 skipped: 3 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 15

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: eaf3052f-09ea-4a47-834e-8b6dff82c0e4

📥 Commits

Reviewing files that changed from the base of the PR and between 0ee725e and 6ef4c78.

📒 Files selected for processing (58)

• .gitmodules
• CMakeLists.txt
• Devices/cl32/CMakeLists.txt
• Devices/cl32/cl32.dts
• Devices/cl32/device.properties
• Devices/cl32/source/cl32_detect.cpp
• Devices/cl32/source/cl32_detect.h
• Devices/cl32/source/cl32_v2.h
• Devices/cl32/source/cl32_v2_keyboard.cpp
• Devices/cl32/source/cl32_v2_keyboard.h
• Devices/cl32/source/cl32_v3.h
• Devices/cl32/source/cl32_v3_keyboard.cpp
• Devices/cl32/source/cl32_v3_keyboard.h
• Devices/cl32/source/cl32_v4.h
• Devices/cl32/source/cl32_v4_keyboard.cpp
• Devices/cl32/source/cl32_v4_keyboard.h
• Devices/cl32/source/cl32_v4_power.cpp
• Devices/cl32/source/cl32_v4_power.h
• Devices/cl32/source/module.cpp
• Devices/heltec-wifi-lora-32-v3/device.properties
• Devices/lilygo-tdeck-max/device.properties
• Devices/lilygo-tdeck-pro/device.properties
• Devices/m5stack-papers3/device.properties
• Drivers/esp-epaper-module/bindings/tuanpmt,esp-epaper.yaml
• Drivers/esp-epaper-module/include/drivers/esp_epaper.h
• Drivers/esp-epaper-module/source/esp_epaper.cpp
• Drivers/tca8418-module/bindings/ti,tca8418.yaml
• Drivers/tca8418-module/include/drivers/tca8418.h
• Drivers/tca8418-module/source/tca8418.cpp
• Libraries/esp_epaper
• Libraries/esp_epaper/.gitignore
• Libraries/esp_epaper/ADDING_PANELS.md
• Libraries/esp_epaper/CMakeLists.txt
• Libraries/esp_epaper/LICENSE
• Libraries/esp_epaper/README.md
• Libraries/esp_epaper/idf_component.yml
• Libraries/esp_epaper/include/epaper.h
• Libraries/esp_epaper/include/epaper_config.h
• Libraries/esp_epaper/include/epaper_lvgl.h
• Libraries/esp_epaper/include/epaper_panel.h
• Libraries/esp_epaper/src/controllers/acep_6color.c
• Libraries/esp_epaper/src/controllers/bwry_4color.c
• Libraries/esp_epaper/src/controllers/gdey0154_lut.c
• Libraries/esp_epaper/src/controllers/ssd16xx.c
• Libraries/esp_epaper/src/epaper.c
• Libraries/esp_epaper/src/epaper_common.c
• Libraries/esp_epaper/src/epaper_common.h
• Libraries/esp_epaper/src/epaper_lvgl.c
• Libraries/esp_epaper/src/epaper_registry.c
• Libraries/esp_epaper/src/epaper_spi.c
• Libraries/esp_epaper/src/epaper_spi.h
• Modules/http-module/source/download.cpp
• Platforms/platform-esp32/source/drivers/esp32_i2c_master.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
• Tactility/Kconfig
• Tactility/Source/lvgl/Statusbar.cpp
• TactilityKernel/source/drivers/battery_sense.cpp
• device.py

💤 Files with no reviewable changes (3)

• Devices/heltec-wifi-lora-32-v3/device.properties
• Libraries/esp_epaper
• .gitmodules

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

Libraries/esp_epaper/src/epaper_lvgl.c (1)

444-449: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Handle epd_flush_framebuffer failures before completing the LVGL flush.

epd_flush_framebuffer returns the esp_err_t from epd_update, but epd_lvgl_flush_cb discards it, clears ctx->fb_dirty, and calls lv_display_flush_ready(disp) unconditionally. If the e-paper update fails, LVGL treats the flush as complete, and this callback provides no retry or error path. Check and handle the result before clearing the dirty state. This callback-level handling is separate from checking discarded SPI transfer statuses inside the e-paper update implementation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b63da065-8e03-4f87-9863-62fb44c943d9

📥 Commits

Reviewing files that changed from the base of the PR and between 27872df and 07bf862.

📒 Files selected for processing (6)

• Modules/cpp-symbols-module/README.md
• Modules/cpp-symbols-module/source/module.cpp
• Platforms/platform-esp32/source/module.cpp
• TactilityKernel/include/tactility/drivers/gpio_controller.h
• TactilityKernel/source/drivers/gpio_controller.cpp
• TactilityKernel/source/symbols.c

💤 Files with no reviewable changes (1)

• Platforms/platform-esp32/source/module.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: dfa45c10-9186-4969-922f-cd2a8025e1c5

📥 Commits

Reviewing files that changed from the base of the PR and between 07bf862 and bebbb57.

📒 Files selected for processing (4)

• Devices/generic-esp32p4/generic,esp32p4.dts
• Devices/guition-jc1060p470ciwy/guition,jc1060p470ciwy.dts
• Devices/m5stack-tab5/m5stack,tab5.dts
• Platforms/platform-esp32/source/module.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.