Tab5, CoreS3, StackChan and app icons - #662
Conversation
Added GC0308 camera driver and wired to CoreS3/Stackchan Changed Stackchan touch to the more reliable ft5x06 driver Added rotation offset to sc2356 camera driver Added optional properties to IMU drivers for swap-xy, swap-xz, swap-yz, invert-x, invert-y, invert-z for accel. fix(m5stack-tab5): hold LCD_RST with a weak pull-up on PI4IO P4 ST7121/ST7123 LCD_RST is a 1.8V pin, so a 3.3V push-pull drive can overvoltage the panel IO. Configure PI4IO-1 P4 as input with a weak pull-up instead. ILI9881C RST accepts 1.65V-3.3V, and all three panels were verified to initialize and run with this change. espressif/esp-bsp#827 Added a few extra shared font icons. Updated esp_audio_codec to 2.5.0, beyond this version has breaking changes for older P4 chip revisions an will not work (yet). App icons are back! Wired in app icons for known apps in the applist and settings. external/unknown apps fallback to LVGL_ICON_SHARED_DEPLOYED_CODE whic AppPackageList also has for consistency. and stuff...
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe changes add a GC0308 camera driver and app, enable camera capture on CoreS3 and StackChan, and add JPEG support dependencies. Three accelerometer drivers gain configurable axis swaps and inversions. The SC2356 driver gains a mounting rotation offset. Shared icons and app-list icons are updated. The Bluetooth status icon includes HID connectivity. Tab5 reset-pin handling and display-orientation detection are updated. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The prior camera-clock pin conflict is addressed, and no other actionable merge risk is established in the supplied changes. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to The new camera path starts capture when its app window opens. The inspected launch path does not show a camera-specific permission check, although it also does not show remote image transfer or a confirmed authorization bypass. Simultaneous-use behavior remains uncertain. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 2.08% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 48 functions across 28 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KenVanHoeylandt
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: caf8b74a-7056-4f54-985c-fa918a6ec773
📒 Files selected for processing (46)
Devices/m5stack-cores3/device.propertiesDevices/m5stack-cores3/devicetree.yamlDevices/m5stack-cores3/m5stack,cores3.dtsDevices/m5stack-stackchan/device.propertiesDevices/m5stack-stackchan/devicetree.yamlDevices/m5stack-stackchan/m5stack,stackchan.dtsDevices/m5stack-tab5/Source/devices/display_detect.cppDevices/m5stack-tab5/m5stack,tab5.dtsDrivers/bmi270-module/bindings/bosch,bmi270.yamlDrivers/bmi270-module/include/drivers/bmi270.hDrivers/bmi270-module/source/bmi270.cppDrivers/gc0308-module/CMakeLists.txtDrivers/gc0308-module/LICENSE-Apache-2.0.mdDrivers/gc0308-module/README.mdDrivers/gc0308-module/bindings/galaxycore,gc0308.yamlDrivers/gc0308-module/devicetree.yamlDrivers/gc0308-module/include/bindings/gc0308.hDrivers/gc0308-module/include/drivers/gc0308.hDrivers/gc0308-module/include/gc0308_module.hDrivers/gc0308-module/source/gc0308.cppDrivers/gc0308-module/source/module.cppDrivers/mpu6886-module/bindings/invensense,mpu6886.yamlDrivers/mpu6886-module/include/drivers/mpu6886.hDrivers/mpu6886-module/source/mpu6886.cppDrivers/qmi8658-module/bindings/qst,qmi8658.yamlDrivers/qmi8658-module/include/drivers/qmi8658.hDrivers/qmi8658-module/source/qmi8658.cppDrivers/sc2356-module/bindings/smartsens,sc2356.yamlDrivers/sc2356-module/include/drivers/sc2356.hDrivers/sc2356-module/source/sc2356.cppDrivers/st7123-module/README.mdModules/lvgl-module/assets/generate-all.pyModules/lvgl-module/include/lvgl/icons/shared.hModules/lvgl-module/source-fonts/material_symbols_shared_12.cModules/lvgl-module/source-fonts/material_symbols_shared_16.cModules/lvgl-module/source-fonts/material_symbols_shared_20.cModules/lvgl-module/source-fonts/material_symbols_shared_24.cModules/lvgl-module/source-fonts/material_symbols_shared_32.cTactility/Source/Tactility.cppTactility/Source/app/applist/AppList.cppTactility/Source/app/apppackagelist/AppPackageList.cppTactility/Source/app/camera/Camera.cppTactility/Source/app/settings/Settings.cppTactility/Source/service/statusbar/Statusbar.cppTactility/Source/settings/DisplaySettings.cppTactility/idf_component.yml
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4f05c0e4-d7de-4303-9d1e-e87cfe02f7fc
📒 Files selected for processing (11)
Devices/m5stack-cores3/m5stack,cores3.dtsDevices/m5stack-cores3/module.yamlDevices/m5stack-stackchan/m5stack,stackchan.dtsDevices/m5stack-stackchan/module.yamlDevices/m5stack-tab5/Source/devices/display_detect.cppDrivers/gc0308-module/bindings/galaxycore,gc0308.yamlDrivers/sc2356-module/source/sc2356.cppTactility/Source/Tactility.cppTactility/Source/app/applist/AppList.cppTactility/Source/app/camera/Camera.cppTactility/Source/app/settings/Settings.cpp
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
|
Thank you!! |
2 participants
Added GC0308 camera driver and wired to CoreS3/Stackchan Changed Stackchan touch to the more reliable ft5x06 driver
Added rotation offset to sc2356 camera driver
Added optional properties to IMU drivers for swap-xy, swap-xz, swap-yz, invert-x, invert-y, invert-z for accel.
fix(m5stack-tab5): hold LCD_RST with a weak pull-up on PI4IO P4
ST7121/ST7123 LCD_RST is a 1.8V pin, so a 3.3V push-pull drive can overvoltage the panel IO. Configure PI4IO-1 P4 as input with a weak pull-up instead. ILI9881C RST accepts 1.65V-3.3V, and all three panels were verified to initialize and run with this change. espressif/esp-bsp#827
Added a few extra shared font icons.
Updated esp_audio_codec to 2.5.0, beyond this version has breaking changes for older P4 chip revisions an will not work (yet).
App icons are back! Wired in app icons for known apps in the applist and settings. external/unknown apps fallback to LVGL_ICON_SHARED_DEPLOYED_CODE whic AppPackageList also has for consistency.
and stuff...
and possibly things...
Summary by CodeRabbit