Skip to content

fix: treat conditional skips as successful runs #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mbeaulne wants to merge 1 commit into
base: conditional-execution-ui
Choose a base branch
from
Draft

fix: treat conditional skips as successful runs #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/utils/executionStatus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,19 @@ describe("getOverallExecutionStatusFromStats()", () => {
).toBe("RUNNING");
});

test("returns succeeded when completed tasks include intentional skips", () => {
expect(
getOverallExecutionStatusFromStats({
SUCCEEDED: 2,
SKIPPED: 1,
}),
).toBe("SUCCEEDED");
});

test("returns skipped when every task was skipped", () => {
expect(getOverallExecutionStatusFromStats({ SKIPPED: 3 })).toBe("SKIPPED");
});

test("returns raw status values (use getExecutionStatusLabel for display)", () => {
expect(
getOverallExecutionStatusFromStats({
Expand Down
2 changes: 1 addition & 1 deletion src/utils/executionStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ const EXECUTION_STATUS_PRIORITY = [
"WAITING_FOR_UPSTREAM",
"QUEUED",
"UNINITIALIZED",
"SKIPPED",
"SUCCEEDED",
"SKIPPED",
] as const;

export type ExecutionStatusStats = Record<string, number>;
Expand Down
Loading