refactor(InfoBox): allow a body-only box - #2665
Closed
camielvs wants to merge 1 commit into
Closed
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
commented
Aug 26, 2026
camielvs
commented
Aug 26, 2026
camielvs
commented
Aug 26, 2026
camielvs
commented
Aug 26, 2026
camielvs
commented
Aug 26, 2026
camielvs
force-pushed
the
banners-02-primitives
branch
from
August 26, 2026 23:45
dc471e3 to
ac56d12
Compare
camielvs
force-pushed
the
banners-01-markdown
branch
from
August 27, 2026 01:18
47a18de to
b525bf9
Compare
camielvs
force-pushed
the
banners-02-primitives
branch
from
August 27, 2026 01:18
ac56d12 to
3a5d8f1
Compare
camielvs
marked this pull request as ready for review
August 28, 2026 00:02
A notice may carry only a body, with no title. Rendering an empty Text still reserved its margin, so the box opened with a blank line above the content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
camielvs
changed the title
camielvs
force-pushed
the
banners-02-primitives
branch
from
August 28, 2026 23:30
3a5d8f1 to
e204342
Compare
Collaborator
Author
|
This has been spun out into #2680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A notice can carry a body with no title.
InfoBoxalways rendered its titleText, so a body-only card opened with an empty semibold line and itsmb-1above the content.What
titlebecomes optional and theTextrenders only when there is one. Every existing caller passes a title and is unaffected.Reviewer notes
Previously this PR also introduced
contentHeight()and a CSS variable for the notice strip to publish its height into. The banners now render inline on the dashboard home rather than as a strip above every route, so nothing publishes that variable — it has been removed. What was left of that change, the plain de-duplication ofcalc(100vh - ${TOP_NAV_HEIGHT}px)across six layouts, is now a standalone PR with no dependency on this stack.The
safe-centeralignment andtabIndexprop this PR added toBlockStack/InlineStackexisted only for the strip's horizontal scroller. That scroller is gone, so they have been dropped rather than left as unused surface.