Add optional course certificate templates - #126
Open
johnwesely wants to merge 5 commits into
Open
Conversation
Hosts can assign a certificate-builder template per course without making the builder a hard dependency. Award Blade certificates stay the fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Optional builder class-strings and EditRecord typing tripped level 4 analysis. Co-authored-by: Cursor <cursoragent@cursor.com>
LMS ships no Course policy; Laravel denies update and hid Create/Edit Certificate Template on Edit Course. Co-authored-by: Cursor <cursoragent@cursor.com>
Hosts can convert existing LMS award certificates into builder templates without waiting on pixel-perfect layouts. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b0144f8. Configure here.
| $blueprint = $this->blueprints->make($awardKey); | ||
| $existing = $templateClass::query() | ||
| ->where('name', $blueprint->templateName) | ||
| ->first(); |
Contributor
There was a problem hiding this comment.
Migrator reuses mismatched templates
Medium Severity
Existing templates are looked up only by name. A {award label} Certificate from Edit Course or another token_set is reused and assigned to every untemplated course for that award. Without --force, token_set is left unchanged, so certificate rendering can resolve the wrong tokens and leave course or user fields blank.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b0144f8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tapp/filament-certificate-builderso hosts can assign a custom template per course without making the builder a hard dependency.filament-lms::certificates.*routes stay the fallback when the integration is off, the package is missing, or no template is assigned.Test plan
certificate_template_idmigration, and confirm Edit Course shows Create Certificate Template.token_setmatches config, course is associated, redirect lands on the designer.filament-lms::certificates.show/downloadrender the builder view; course without a template still uses the award Blade.Made with Cursor