Course reporting scoped to tenant - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Course reporting scoped to tenant.
Note
Medium Risk
Changes reporting data boundaries in multi-tenant setups; incorrect scoping could expose other tenants’ progress, though behavior is covered by new tests and reuses existing tenant column helpers.
Overview
Course completion reporting now respects LMS tenancy: when
filament-lms.tenancy.enabledis on and a Filament tenant is active,CourseProgressQueryService::buildQuery()only includes progress for courses belonging to that tenant (viaTenantHelper’s tenant column). If tenancy is enabled but no tenant is selected, the report stays unscoped (all tenants), matching the new test expectation.The User filter on the Reporting page no longer loads every user from
users; it uses newreportUserFilterOptions(), which lists emails only for learners that appear in the (tenant-scoped) report query—so exports and filters stay aligned with the table.Feature tests cover tenant isolation, filter options, and the no-tenant-selected case; a minimal
TestTeammodel supports tenancy in tests.Reviewed by Cursor Bugbot for commit b0cee4b. Bugbot is set up for automated code reviews on this repo. Configure here.