Change unique course fields per tenant - #128
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1ac487e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
Change unique course fields (
name,slug, andexternal_id) per tenant.Note
Medium Risk
Schema migration changes uniqueness rules on a core table; misconfiguration or partial deploy could affect course creation, but behavior is gated on tenancy config and covered by tests.
Overview
Enables separate tenants to reuse the same course
name,slug, andexternal_idwithout colliding, aligning DB constraints and admin validation with multi-tenant LMS usage.When tenancy is enabled and the tenant column exists on
lms_courses, a new published migration drops global unique indexes on those three columns and adds composite uniques on[tenant_column, column]. The migration is idempotent on re-run, skips work when tenancy is off, and intentionally leavesdown()empty so rollback does not try to restore global uniques after cross-tenant duplicates may exist.Course admin forms now use
scopedUniqueinstead ofuniqueonname,external_id, andslugso Filament validation matches the tenant-scoped indexes. Feature tests cover index shape, no-op when tenancy is disabled, and rollback behavior.Reviewed by Cursor Bugbot for commit febf572. Bugbot is set up for automated code reviews on this repo. Configure here.