-
Notifications
You must be signed in to change notification settings - Fork 6
fix: mobile image step overflow and tap-to-zoom lightbox #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| <?php | ||
|
|
||
| namespace Tapp\FilamentLms\Tests\Feature; | ||
|
|
||
| use Illuminate\Contracts\Support\MessageBag as MessageBagContract; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
| use Illuminate\Support\MessageBag; | ||
| use Livewire\Livewire; | ||
| use Tapp\FilamentLms\Livewire\ImageStep; | ||
| use Tapp\FilamentLms\Models\Course; | ||
| use Tapp\FilamentLms\Models\Image; | ||
| use Tapp\FilamentLms\Models\Lesson; | ||
| use Tapp\FilamentLms\Models\Step; | ||
| use Tapp\FilamentLms\Tests\TestUser; | ||
|
|
||
| class ImageStepWithErrorBag extends ImageStep | ||
| { | ||
| public function getErrorBag(): MessageBagContract | ||
| { | ||
| return new MessageBag; | ||
| } | ||
| } | ||
|
|
||
| beforeEach(function () { | ||
| if (! Schema::hasColumn('lms_images', 'deleted_at')) { | ||
| Schema::table('lms_images', function (Blueprint $table) { | ||
| $table->softDeletes(); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| test('image step wraps the image in the material container', function () { | ||
| $user = TestUser::create([ | ||
| 'name' => 'Test User', | ||
| 'email' => 'image-step@example.com', | ||
| 'password' => bcrypt('password'), | ||
| ]); | ||
|
|
||
| $this->actingAs($user); | ||
|
|
||
| $course = Course::factory()->create(); | ||
| $lesson = Lesson::factory()->create(['course_id' => $course->id]); | ||
|
|
||
| $image = Image::query()->create([ | ||
| 'name' => 'Landscape', | ||
| 'file_path' => 'images/landscape.png', | ||
| ]); | ||
|
|
||
| $path = sys_get_temp_dir().'/lms-landscape-test.png'; | ||
| $png = imagecreatetruecolor(16, 9); | ||
| imagepng($png, $path); | ||
|
|
||
| $image->addMedia($path)->preservingOriginal()->toMediaCollection('image'); | ||
|
|
||
| $step = Step::factory()->create([ | ||
| 'lesson_id' => $lesson->id, | ||
| 'name' => 'Landscape Image', | ||
| 'slug' => 'landscape-image', | ||
| 'material_type' => 'image', | ||
| 'material_id' => $image->id, | ||
| ]); | ||
|
|
||
| $html = Livewire::test(ImageStepWithErrorBag::class, ['step' => $step->fresh(['material'])])->html(); | ||
|
|
||
| expect($html) | ||
| ->toContain('class="step-material-container"') | ||
| ->toContain('<img') | ||
| ->toContain('role="dialog"') | ||
| ->toContain('Tap to zoom') | ||
| ->not->toContain('class="step-material-container rounded-lg'); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backdrop click cannot close lightbox
Medium Severity
@click.selfon.lms-image-lightboxnever runs because.lms-image-lightbox__scrolleris sized to100%width and height and sits on top of the dialog, so taps hit the scroller instead of the lightbox. Close and Escape still work, but the advertised backdrop dismiss does not.Additional Locations (1)
resources/css/plugin.css#L223-L230Reviewed by Cursor Bugbot for commit 43df6cd. Configure here.