fix(maths): use specific exception types in collatz_sequence#14769
Open
fauzan171 wants to merge 1 commit into
Open
fix(maths): use specific exception types in collatz_sequence#14769fauzan171 wants to merge 1 commit into
fauzan171 wants to merge 1 commit into
Conversation
Replace generic Exception with TypeError for non-integer inputs and ValueError for non-positive integers. Split the combined validation check into two separate checks for clearer error reporting. This follows Python best practices for exception handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the generic
Exceptionwith appropriate specific exception types (TypeErrorandValueError) in thecollatz_sequence()input validation.Changes
if not isinstance(n, int) or n < 1check into two separate checksTypeErrorwhen input is not an integer (e.g., float, string)ValueErrorwhen input is an integer but not positive (e.g., 0, -1)Why
Using
Exceptionis a Python anti-pattern. Specific exception types allow callers to handle different error cases appropriately:TypeError: wrong input typeValueError: correct type but invalid valueThis follows the same pattern used by other functions in this repository (e.g.,
juggler_sequence(),liouville_lambda(),twin_prime()).Checklist