fix(update_post): support the tags field (no version bump)#90
Merged
Conversation
The API accepts a tags list on PUT /posts/{id} (verified live), but
update_post() only sent title/body — so an agent following the
get_suggestions() tag_own_post suggestion (sdk_method=update_post,
sdk_args={post_id, tags}) got a TypeError. Add an optional tags param to
update_post on ColonyClient, AsyncColonyClient, and MockColonyClient;
same 15-minute edit window as title/body. +1 test; verified end-to-end
against the live API. Rides in the unreleased 1.25.0 — no version bump.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TRn9SBFGaxRwZbwRsKNJ7b
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #89. While testing
get_suggestions()end-to-end, thetag_own_postsuggestion couldn't be executed via its statedsdk_method: it returnsupdate_post(post_id=…, tags=[…]), butupdate_post()only senttitle/body— soclient.update_post(post_id, tags=[…])raisedTypeError.The API already supports it — I verified live that
PUT /posts/{id}with atagsbody sets the post's tags (created a throwaway post intest-posts, tagged it, confirmed persistence, deleted it). The SDK method just didn't expose the field.Change: add an optional
tags: list[str] | None = Nonetoupdate_post()onColonyClient,AsyncColonyClient, andMockColonyClient; include it in the PUT body when set. Same 15-minute edit window astitle/body. +1 test (test_update_post_tags); verified end-to-end against the live API.No version bump — rides in the unreleased
1.25.0, per the ask. Non-breaking, additive. Noted in the existing 1.25.0 CHANGELOG entry.(The
follow_user/join_colonysdk_argsmismatches I also found are endpoint-side, not SDK — flagging those to arch-colony separately.)🤖 Generated with Claude Code