feat(af02): add T018 corpus and assertion contracts - #73
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (5)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/settings/billing. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
You're on the cubic free plan with 7 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
External qualification blocker — exact-head runner startCurrent candidate: All five canonical pull-request workflows are present on this exact head but terminate before any runner step begins:
The same pre-step condition reproduced on the temporary branch-only qualification lane and after an explicit failed-job rerun on the previous exact head. No failing command, test, build, audit, or verifier step exists to diagnose because runner execution never starts. Repository metadata currently reports visibility Cubic's two substantive T018 findings were fixed on this head and their threads are resolved. Qodo/Greptile remain unavailable due trial state; CodeRabbit is currently rate-limited. None of those availability states is treated as PASS. No required check will be bypassed or weakened. T018 remains non-canonical and unmerged until exact-head workflows can execute and succeed. |
Current external qualification blockerLive recheck on 2026-08-29 confirms the repository remains private and PR #73 remains on exact head A fresh retry of canonical This remains an external GitHub Actions runner-start condition. It is not classified as a code/test failure and is not PASS evidence. Required checks are not bypassed or weakened. Repository-side review state is otherwise clean: both substantive Cubic findings are fixed on the current exact head and their review threads are resolved. T018 remains non-canonical until exact-head required workflows can execute and succeed. Per canonical task order, T019 is not started before T018 canonicalization. |
|
External execution blocker diagnosis update (2026-08-29):
Required external remediation is therefore account-level: restore GitHub Actions hosted-runner eligibility for this private repository (valid billing/payment method and sufficient Actions budget/quota, or GitHub Support if the account is in a GitHub-controlled disabled state). Repository visibility is intentionally not changed as a workaround. No PASS is claimed. T018 remains non-canonical until the required exact-head workflows execute and succeed. |
Summary
Implement AF-02 T018 corpus/assertion contract infrastructure from canonical T017 source
94bf4f1a9987f474613e67ddbc182ece8dff5a8d.Scope
This candidate changes exactly five paths:
specs/016-af-02-adversarial-test-strength/corpus-manifest.jsonspecs/016-af-02-adversarial-test-strength/assertion-registry.jsontools/af02-verifier/src/corpus.rstools/af02-verifier/src/lib.rstools/af02-verifier/src/main.rsNo schema, surface policy, resource policy, workflow, Cargo input, dependency, product source, fuzz/property/replay/coverage/mutation result, or live ruleset changes are included.
Canonical design seed
The retained corpus starts with zero scenarios and the assertion registry starts with zero assertions. This establishes the A0 contract without using dependent execution outcomes to prove A0.
The corpus freezes the planning-defined limits:
contains_phi = falsefor every future retained scenarioExact empty corpus SHA-256:
31b60a670f66d37dbbe039456b9f1a0fab95a75e880f3026f88e871b8a737a10The assertion registry binds that exact digest and the canonical surface-policy SHA-256
dbd4a455d03e0bc4068155c1927bd827d3d1204fb26a0b7cb55e38c1b4abcf26.Validator behavior
The verifier:
af02-corpus-v1.schema.jsonGit blob;contains_phi = false;parse-corpusandparse-assertions;CARGO_TESTversusAF02_REPLAY_BINARY;fs::readboundary and rejects missing files, observed sizes above the frozen per-fixture limit, declared/observed length mismatches, and SHA-256 mismatches.No new executable authority surface is introduced. T022 remains responsible for the stronger base-gate untrusted-input symlink/containment and pre-read input ceilings.
Tests
Owned unit tests cover:
Cubic findings on the initial head were fixed on
292702d711328e7ce06c36cc4f2928cdfa0aded3and both review threads are resolved.Qualification state
Two temporary branch-only qualification attempts (
33256288688,33256366561) failed before any runner step began (steps=[]) and the temporary workflow was removed from the final candidate.On the current exact head
292702d711328e7ce06c36cc4f2928cdfa0aded3, all five canonical pull-request workflows also terminate before any runner step begins. This is recorded as an external GitHub Actions runner-start condition, not as PASS evidence and not as a product/test failure. No required check is bypassed or weakened.Exact-head CI remains required before merge; T018 is not canonical until those workflows can execute and succeed.