feat: Terrain conforming particles - #3245
Draft
stephanmeesters wants to merge 7 commits into
Draft
Conversation
Squash merge of Mauller/perf-batch-particle-draws.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge by rebase
This adds a new render method for particles by allowing them to be terrain conforming. This feature can be enabled for a particle system by using the new INI option
IsGroundConforming. The feature as a whole can be enabled/disabled by using the new defineENABLE_TERRAIN_CONFORMING_PARTICLES. It has been integrated with Mauller/Ronin's particle batching.Design decisions -- todo
Testing
This can be tested by building Patch2 with a modification to particle systems see the data PR.
Alternatively, you can cherry-pick this commit:
Or use this test build which force-enables the terrain conforming particles.
Performance impact
The test build was used to test a moderately heavy scene (3 nuke cannons + 3 nukes shooting at a hill in Alpine Assault) using a Macbook Pro 2013 base spec aka Potato, which showed a 5.5% average FPS loss.
Test results
Image gallery
More
Todo