Skip to content

bugfix(audio): Copy sound scene state safely #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CryoTheRenegade wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

bugfix(audio): Copy sound scene state safely #3247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Core/Libraries/Source/WWVegas/WWAudio/SoundSceneObj.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ SoundSceneObjClass::SoundSceneObjClass ()
m_PhysWrapper (nullptr),
m_pCallback (nullptr),
m_AttachedObject (nullptr),
m_AttachedBone (-1),
m_UserData (0),
m_UserObj (nullptr),
m_ID (SOUND_OBJ_DEFAULT_ID),
Expand All @@ -110,18 +111,22 @@ SoundSceneObjClass::SoundSceneObjClass ()
//
////////////////////////////////////////////////////////////////////////////////////////////////
SoundSceneObjClass::SoundSceneObjClass (const SoundSceneObjClass &src)
: m_Scene (nullptr),
: m_Scene (src.m_Scene),
m_PhysWrapper (nullptr),
m_pCallback (nullptr),
m_pCallback (src.m_pCallback),
m_AttachedObject (nullptr),
m_AttachedBone (src.m_AttachedBone),
m_UserData (0),
m_UserObj (nullptr),
m_ID (SOUND_OBJ_DEFAULT_ID),
m_RegisteredEvents (AudioCallbackClass::EVENT_NONE)
m_RegisteredEvents (src.m_RegisteredEvents)
{
m_ID = m_NextAvailableID ++;

(*this) = src;
// TheSuperHackers @bugfix Cryo 01/09/2026 Copy the attachment without invoking virtual positioning
// before the derived sound object has been constructed.
REF_PTR_SET (m_AttachedObject, src.m_AttachedObject);
PersistClass::operator= ((const PersistClass &)src);
Register_Sound_Object (this);
}

Expand Down
Loading