fix(explorer): support multi-file drag and folder content drops - #234
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The Explorer already supported multi-selection and bulk overflow actions, but drag start stored only one document ID. Folder drops were also bound only to the folder-name row, so dropping over files inside an expanded folder fell through to another location.
The updated behavior follows familiar Finder and VS Code conventions: dragging one item from a selection operates on the complete selection, and an open folder behaves as a destination across its visible contents.
User impact
Users can now select several Markdown files and drag them together. They can drop on a folder name, on an existing file inside an expanded folder, or into an expanded empty folder. Hover expansion, Explorer auto-scroll, keyboard/touch Move to…, and bulk more-options actions remain available.
Validation
node --check script.jsnode --check desktop-app/resources/js/script.jsnpm run buildnode desktop-app/prepare.jswith offline asset validationgit diff --check