-
Notifications
You must be signed in to change notification settings - Fork 217
chore: add indictment support to Bavet's Node Network #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Christopher-Chianelli
wants to merge
18
commits into
TimefoldAI:main
Choose a base branch
from
Christopher-Chianelli:feat/729
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a0d90a2
feat: add plumbing for indictment support
Christopher-Chianelli dac65ef
chore: remove creating a new tuple for `ifExists` indictments
Christopher-Chianelli bd643db
chore: use a Map to store extra indicted objects from ifExists
Christopher-Chianelli 84d5815
chore: make UniConstraintStream tests aware of indictments
Christopher-Chianelli b67e780
fix: remove old indicted objects from original group in GroupNode
Christopher-Chianelli 57b24b1
chore: move indictment code for IfExists to IndictmentSource
Christopher-Chianelli 83b2569
chore: track support in indictment, not tuple
Christopher-Chianelli 478bcd2
chore: make getIndictedObjects() return null when indictments disable…
Christopher-Chianelli 246608f
test: add tests for BiConstraintStream indictments
Christopher-Chianelli c6b5034
test: make TriConstraintStream tests indictment aware
Christopher-Chianelli e720515
test: Make BavetQuadConstraintStreamTest aware of indictments
Christopher-Chianelli 8714603
test: make AdvanceGroupByTest aware of indictments
Christopher-Chianelli 15031ef
test: make BavetRegressionTest aware of indictments
Christopher-Chianelli 4dfea10
fix: Propagate updates to indictments in ifExists even if left side d…
Christopher-Chianelli 70a6eff
fix: update left indicted set even if its key not changed for indexed…
Christopher-Chianelli 04622f2
test: make TriPrecompute test indictment aware
Christopher-Chianelli a1b0cb5
test: make QuadPrecompute tests indictment aware
Christopher-Chianelli b438f8b
chore: merge fixes
Christopher-Chianelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cases like this would benefit from inheriting the indictment source at construction time; the mutability aspect will probably be necessary in some places (haven't yet read the entire thing), but I think the default pattern here should not happen post-construction.