Skip to content

Release v1.10.38 test with Presence+ - #77

Merged
Tiwas merged 1 commit into
mainfrom
release/presence-plus-v1.10.38
Oct 14, 2026
Merged

Tiwas merged 1 commit into
mainfrom
release/presence-plus-v1.10.38

Conversation

@Tiwas

@Tiwas Tiwas commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • add Presence+ delayed-away triggers for a selected person and for everyone
  • re-arm a new absence when the previous trigger call is still settling
  • fix Circadian Collection pause detection
  • update the website, README, changelog, and Homey Community post source for v1.10.38

Verification

  • 25 test suites and 427 tests passed
  • publish-level Homey package validation passed
  • live Home/Away/Home/Away reproduction passed
  • v1.10.38 is available on the Homey test channel and installed locally

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T13:12:27.537676Z 5f4e4cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Tiwas
Tiwas merged commit ee1d6a7 into main Oct 14, 2026
2 checks passed
@Tiwas
Tiwas deleted the release/presence-plus-v1.10.38 branch October 14, 2026 13:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f4e4cd297

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


this.inFlight.add(inFlightKey);
try {
await this.personTriggerCard.trigger({

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Record fired episodes before waiting for the trigger

If the app restarts after Homey accepts this trigger but before the returned promise settles, the fired marker has not yet been persisted. Startup restores the same absentSince, schedules the overdue threshold immediately, and triggers the matching Flows a second time. The same ordering exists in fireEveryone, so both Presence+ cards can violate the promised restart deduplication; persist an in-flight/fired episode before awaiting the potentially long-running trigger call.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant