Repository navigation
Release v1.10.38 test with Presence+ - #77
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4e4cd297
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| this.inFlight.add(inFlightKey); | ||
| try { | ||
| await this.personTriggerCard.trigger({ |
There was a problem hiding this comment.
Record fired episodes before waiting for the trigger
If the app restarts after Homey accepts this trigger but before the returned promise settles, the fired marker has not yet been persisted. Startup restores the same absentSince, schedules the overdue threshold immediately, and triggers the matching Flows a second time. The same ordering exists in fireEveryone, so both Presence+ cards can violate the promised restart deduplication; persist an in-flight/fired episode before awaiting the potentially long-running trigger call.
Useful? React with 👍 / 👎.
Summary
Verification