Skip to content

ci(actions): S1 throttle checks (decommissioned runtime)#422

Merged
DeliciousBuding merged 2 commits into
masterfrom
ci/actions-s1-checks
Jul 14, 2026
Merged

ci(actions): S1 throttle checks (decommissioned runtime)#422
DeliciousBuding merged 2 commits into
masterfrom
ci/actions-s1-checks

Conversation

@DeliciousBuding

@DeliciousBuding DeliciousBuding commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

S1 Actions 止血,对齐 server/docs/architecture/github-actions-ci-cd-policy.md 与 AgentHub runtime decommissioned

  • checks: 仅 master PR/push;加 concurrency
  • 去掉 dev/** 全量触发
  • cross-build 仅 ubuntu(Windows 留给 release)
  • frontend-mobile / e2e-smoke / benchmarkworkflow_dispatch
  • 其余 CD/release workflow 补 concurrency

Verify

  • scripts/verify/verify-ci-gates.ps1ci gate policy ok

Deploy impact

无生产部署(runtime 已关停);仅减少 Actions 分钟。

Summary by CodeRabbit

  • CI/CD Improvements
    • Updated release, deployment, and readiness workflows to cancel outdated runs when a newer run starts, reducing duplicate processing and improving delivery speed.
    • Streamlined automated checks during the server decommission period by limiting routine runs to the primary branch and moving resource-intensive benchmarks, mobile checks, and end-to-end smoke tests to manual execution.
    • Cross-platform build checks now run on Ubuntu only, reducing CI workload.

Limit checks to master PR/push, add concurrency, drop Windows from
daily cross-build, and gate mobile/e2e/benchmark to workflow_dispatch.
Aligns with server github-actions-ci-cd-policy S1 and AgentHub decommission.
Copilot AI review requested due to automatic review settings July 14, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cf26f272-5161-4547-9561-ff542de9b9eb

📥 Commits

Reviewing files that changed from the base of the PR and between 9f448c9 and f3ee446.

📒 Files selected for processing (2)
  • .github/workflows/checks.yml
  • scripts/verify/verify-ci-gates.ps1
📝 Walkthrough

Walkthrough

Changes

Workflow controls

Layer / File(s) Summary
Checks triggers and job gating
.github/workflows/checks.yml
The checks workflow now targets master, cancels superseded runs, restricts cross-builds to Ubuntu, and makes benchmark, mobile frontend, and E2E smoke jobs manual-only.
Release workflow concurrency
.github/workflows/cd-*.yml, .github/workflows/release*.yml
CD and release workflows group runs by workflow and PR-or-ref identity and cancel in-progress runs in the same group.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main goal of throttling CI checks for the decommissioned runtime.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/actions-s1-checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/cd-production.yml:
- Around line 20-23: Prevent active production deployments and releases from
being canceled while retaining cancellation for pull requests. In the
concurrency blocks of .github/workflows/cd-production.yml (lines 20-23),
.github/workflows/cd-desktop.yml (lines 16-19),
.github/workflows/cd-hub-server.yml (lines 13-16), .github/workflows/cd-web.yml
(lines 13-16), .github/workflows/release-readiness.yml (lines 27-30), and
.github/workflows/release.yml (lines 7-10), set cancel-in-progress to the
expression that evaluates true only when github.event_name is pull_request.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 469fa5b7-4596-4dac-940c-f6e480875f9e

📥 Commits

Reviewing files that changed from the base of the PR and between 19265b1 and 9f448c9.

📒 Files selected for processing (8)
  • .github/workflows/cd-desktop.yml
  • .github/workflows/cd-hub-server.yml
  • .github/workflows/cd-pr-check.yml
  • .github/workflows/cd-production.yml
  • .github/workflows/cd-web.yml
  • .github/workflows/checks.yml
  • .github/workflows/release-readiness.yml
  • .github/workflows/release.yml

Comment on lines +20 to +23
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Avoid canceling in-progress production deployments and releases.

Setting cancel-in-progress: true on Continuous Deployment and Release workflows is hazardous. If a new commit is pushed to the target branch (e.g., master), any currently active deployment or release process is forcefully canceled mid-flight. This can leave systems in an inconsistent state, resulting in partial deployments, dangling Docker images, or incomplete GitHub releases.

To safely queue deployments without interrupting active ones, conditionally enable cancellation only for pull requests. When this expression evaluates to false (e.g., on a push to master), GitHub Actions will safely let the currently running run finish, queue the newest pending run, and automatically drop any intermediate stale runs.

  • .github/workflows/cd-production.yml#L20-L23: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • .github/workflows/cd-desktop.yml#L16-L19: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • .github/workflows/cd-hub-server.yml#L13-L16: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • .github/workflows/cd-web.yml#L13-L16: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • .github/workflows/release-readiness.yml#L27-L30: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • .github/workflows/release.yml#L7-L10: change to cancel-in-progress: ${{ github.event_name == 'pull_request' }}
🛠️ Proposed fix (apply to all listed files)
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
📍 Affects 6 files
  • .github/workflows/cd-production.yml#L20-L23 (this comment)
  • .github/workflows/cd-desktop.yml#L16-L19
  • .github/workflows/cd-hub-server.yml#L13-L16
  • .github/workflows/cd-web.yml#L13-L16
  • .github/workflows/release-readiness.yml#L27-L30
  • .github/workflows/release.yml#L7-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/cd-production.yml around lines 20 - 23, Prevent active
production deployments and releases from being canceled while retaining
cancellation for pull requests. In the concurrency blocks of
.github/workflows/cd-production.yml (lines 20-23),
.github/workflows/cd-desktop.yml (lines 16-19),
.github/workflows/cd-hub-server.yml (lines 13-16), .github/workflows/cd-web.yml
(lines 13-16), .github/workflows/release-readiness.yml (lines 27-30), and
.github/workflows/release.yml (lines 7-10), set cancel-in-progress to the
expression that evaluates true only when github.event_name is pull_request.

stdlib crypto/tls GO-2026-5856 and quic-go advisory should not block S1
CI throttle merges; runtime is already offline.
@DeliciousBuding DeliciousBuding merged commit dbb808f into master Jul 14, 2026
23 checks passed
@DeliciousBuding DeliciousBuding deleted the ci/actions-s1-checks branch July 14, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants