ci(actions): S1 throttle checks (decommissioned runtime)#422
Conversation
Limit checks to master PR/push, add concurrency, drop Windows from daily cross-build, and gate mobile/e2e/benchmark to workflow_dispatch. Aligns with server github-actions-ci-cd-policy S1 and AgentHub decommission.
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesWorkflow controls
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cd-production.yml:
- Around line 20-23: Prevent active production deployments and releases from
being canceled while retaining cancellation for pull requests. In the
concurrency blocks of .github/workflows/cd-production.yml (lines 20-23),
.github/workflows/cd-desktop.yml (lines 16-19),
.github/workflows/cd-hub-server.yml (lines 13-16), .github/workflows/cd-web.yml
(lines 13-16), .github/workflows/release-readiness.yml (lines 27-30), and
.github/workflows/release.yml (lines 7-10), set cancel-in-progress to the
expression that evaluates true only when github.event_name is pull_request.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 469fa5b7-4596-4dac-940c-f6e480875f9e
📒 Files selected for processing (8)
.github/workflows/cd-desktop.yml.github/workflows/cd-hub-server.yml.github/workflows/cd-pr-check.yml.github/workflows/cd-production.yml.github/workflows/cd-web.yml.github/workflows/checks.yml.github/workflows/release-readiness.yml.github/workflows/release.yml
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Avoid canceling in-progress production deployments and releases.
Setting cancel-in-progress: true on Continuous Deployment and Release workflows is hazardous. If a new commit is pushed to the target branch (e.g., master), any currently active deployment or release process is forcefully canceled mid-flight. This can leave systems in an inconsistent state, resulting in partial deployments, dangling Docker images, or incomplete GitHub releases.
To safely queue deployments without interrupting active ones, conditionally enable cancellation only for pull requests. When this expression evaluates to false (e.g., on a push to master), GitHub Actions will safely let the currently running run finish, queue the newest pending run, and automatically drop any intermediate stale runs.
.github/workflows/cd-production.yml#L20-L23: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}.github/workflows/cd-desktop.yml#L16-L19: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}.github/workflows/cd-hub-server.yml#L13-L16: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}.github/workflows/cd-web.yml#L13-L16: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}.github/workflows/release-readiness.yml#L27-L30: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}.github/workflows/release.yml#L7-L10: change tocancel-in-progress: ${{ github.event_name == 'pull_request' }}
🛠️ Proposed fix (apply to all listed files)
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
- cancel-in-progress: true
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| cancel-in-progress: true | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} |
📍 Affects 6 files
.github/workflows/cd-production.yml#L20-L23(this comment).github/workflows/cd-desktop.yml#L16-L19.github/workflows/cd-hub-server.yml#L13-L16.github/workflows/cd-web.yml#L13-L16.github/workflows/release-readiness.yml#L27-L30.github/workflows/release.yml#L7-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/cd-production.yml around lines 20 - 23, Prevent active
production deployments and releases from being canceled while retaining
cancellation for pull requests. In the concurrency blocks of
.github/workflows/cd-production.yml (lines 20-23),
.github/workflows/cd-desktop.yml (lines 16-19),
.github/workflows/cd-hub-server.yml (lines 13-16), .github/workflows/cd-web.yml
(lines 13-16), .github/workflows/release-readiness.yml (lines 27-30), and
.github/workflows/release.yml (lines 7-10), set cancel-in-progress to the
expression that evaluates true only when github.event_name is pull_request.
stdlib crypto/tls GO-2026-5856 and quic-go advisory should not block S1 CI throttle merges; runtime is already offline.
Summary
S1 Actions 止血,对齐
server/docs/architecture/github-actions-ci-cd-policy.md与 AgentHub runtime decommissioned。checks: 仅masterPR/push;加 concurrencydev/**全量触发cross-build仅 ubuntu(Windows 留给 release)frontend-mobile/e2e-smoke/benchmark仅workflow_dispatchVerify
scripts/verify/verify-ci-gates.ps1→ci gate policy okDeploy impact
无生产部署(runtime 已关停);仅减少 Actions 分钟。
Summary by CodeRabbit