Conversation
kasbah
commented
Sep 14, 2026
kasbah
commented
Member
kasbah
added this pull request to stack #1498
September 14, 2026 14:16
kasbah
force-pushed
the
kb/llm-conversation-retry
branch
from
September 14, 2026 15:28
24b9a4a to
2480918
Compare
kasbah
force-pushed
the
kb/llm-conversation-retry
branch
from
September 14, 2026 15:47
2480918 to
a502b79
Compare
tslil-topos
requested changes
Sep 14, 2026
tslil-topos
left a comment
tslil-topos
left a comment
Collaborator
There was a problem hiding this comment.
i don't know how to actually force this situation for testing, so it's difficult for me to gauge whether we're honouring the ephemeral display of attempts in the return value of LLMConversationTurnResult.
That aside, seems to me like we're duplicating a check?
| ); | ||
| const result = await run(key); | ||
| if (result.tag === "Retryable") { | ||
| const latestInteraction = conversation().interactions().at(-1); |
Collaborator
There was a problem hiding this comment.
i don't think you should need to do this, retryLastLLMConversation already deals with this case
export async function retryLastLLMConversationResponse<...>(...): Promise<LLMConversationTurnResult> {
...
if (conversation.interactions().at(-1)?.tag !== "user-message") {
return { tag: "Failed", error: "The latest interaction is not a user message." };
}
...
}did you notice a deficiency?
kasbah
marked this pull request as draft
September 14, 2026 16:04
epatters
added
enhancement
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.