Skip to content

Integration between modules is tested only for the kernel, and an integration test outside it is cut #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Japabu merged 2 commits into from
Oct 12, 2026
Merged

Integration between modules is tested only for the kernel, and an integration test outside it is cut #890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e5841
Integration between modules is tested only for the kernel, and an int…
Japabu Oct 12, 2026
99c1391
Merge origin/main (ab655a115: #861) into wt/toyos-test-ruling
Japabu Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .claude/agents/reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,14 @@ if it meets the bar above; otherwise it is a NOTE.
exists, or made smaller? An abstraction with one caller, a parameter with one value, dead code,
code kept "just in case" or because nobody knows whether it is needed. Size is never bought with
a weaker check: a test is cut only when it tests nothing or is a measurement, when this prompt
takes its rule, or as **Guest tests** says. A compromise the branch found is removed or
recorded in `issues/` with an owner, evidence and an exit condition.
- **Tests.** The refusals and the boundary, not the happy path. A test is hermetic, deterministic
takes its rule, when **Tests** cuts it, or as **Guest tests** says. A compromise the branch
found is removed or recorded in `issues/` with an owner, evidence and an exit condition.
- **Tests.** The refusals and the boundary, not the happy path, and integration between modules
only for the kernel: outside it, a userspace program is tested as units and modules with at most
a very cheap smoke test, and no test installs or launches software and drives it through a
sequence of steps. An integration test refused here is cut, and where what it checked matters, a
unit or module test of its program holds it, named in the pull request body. A test is
hermetic, deterministic
and makes one claim, in setup, act and assert under a name that says the claim, and it reaches
no internet. However loaded the host, no guest test goes red: a guest test's only clock is a
hang ceiling, and timing is valid only on metal. A timing row on the T14 is a test, and it goes
Expand All @@ -144,7 +149,8 @@ if it meets the bar above; otherwise it is a NOTE.
- **Guest tests.** A behaviour is tested on root `CLAUDE.md`'s cheapest tier that reaches it. A new
guest test, or one whose behaviour changes, whose pull request body does not say why a type, a
host test and a metal row cannot reach its behaviour is a BLOCKER, and so is one whose reason a
cheaper tier answers. A guest test is cut only where it is a measurement (**Tests**); where a
cheaper tier answers. A guest test is cut only where it is a measurement (**Tests**); where
**Tests** cuts it; where a
cheaper tier already holds its behaviour, named in the pull request body; where a stage of a
track names it, in the same diff, with the behaviour it guarded and an exit a build or test can
fail; or as root `CLAUDE.md` deletes a red or flaky test. Any other cut is a BLOCKER.
Expand Down