docs: recognize eutialia's runtime reports and proposals - #1339
Conversation
--allowedTools covers Bash only, so Write/Edit fell through to the permission prompt claude -p has nobody to answer. Headless Issues that write a report, append to a watchlist, or update a map lost their output and reported every Write/Edit call denied by the sandbox. pi passes --approve and agy passes --dangerously-skip-permissions under Docker; claude was the only adapter that could not persist. acceptEdits grants file writes and leaves Bash gated, so the allowlist keeps its meaning instead of being replaced by a blanket bypass. Verified against Claude Code 2.1.237: auto and dontAsk are both no-ops headless, they still escalate to an unanswerable prompt, so acceptEdits is the only mode that works. Write-class Bash stays denied, so git commit in an Issue body still fails. Narrow Bash(git add:*) / Bash(git commit:*) prefixes are a separate follow-up.
|
@eutialia is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
🔵 Needs a closer look
It changes runtime permission behavior for a headless agent process and depends on external Claude Code flag semantics/compatibility that can’t be fully validated from the diff alone.
Pull request overview
Enables non-interactive Claude Code (claude -p) runs to successfully perform file Write/Edit operations within a Workspace by explicitly setting a headless-specific permission mode, preventing tool calls from falling through to an unanswerable prompt during scheduled/automated runs.
Changes:
- Add a headless-only
--permission-mode acceptEditsflag to the Claude adapter’s headless argv. - Update the headless argv composition test to assert the new flag is present in the expected position.
File summaries
| File | Description |
|---|---|
| src/workspaces/adapters/claude.ts | Adds a dedicated headless permission mode constant and passes --permission-mode acceptEdits for claude -p runs. |
| src/workspaces/adapters/ai-config.spec.ts | Updates the composeHeadlessCommand expectation for Claude to include the new permission-mode flag. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
claude code usually has this kind of strange actions. Thanks for your PR . I will merge it after 0.91.0 launch. |
|
Thanks for your fix! We detect a similar prob and fix it today on 36a3463. But I miss your PR. I will add you in the contributor as one of our delicious friends. : ) |
luokerenx4
changed the title
Contributor recognition
Credit @eutialia in CONTRIBUTORS.md and the README contributor gallery for identifying the headless Claude Write/Edit permission gap and proposing a fix. Also record their Docker stale-lock recovery (#1363) and IBKR capability/transport (#1364) proposals; those remain separate PRs and are not represented as shipped here.
Why this PR changed
The original proposal added
--permission-mode acceptEditsso unattended Claude runs could persist their work. Current dev already addresses that problem through the unified full-access launch policy in 36a3463, so the adapter patch is superseded.At the maintainer's request, this PR now carries contributor recognition. The original author's commit is preserved, dev is merged into the branch, and the final diff contains only README.md and CONTRIBUTORS.md. Runtime behavior is unchanged.
Validation
git diff --check origin/devpasses.Thank you for investigating practical runtime failures and contributing multiple concrete proposals.