Allow no null byte on WKT - #8
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
57eb4b2 to
97f667e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves LAS WKT VLR parsing to handle files where the WKT payload is not NUL-terminated (some writers store WKT across the full record_length_after_header), and adds regression tests to cover both coordinate-system and math-transform WKTs in NUL-terminated and non-NUL-terminated forms.
Changes:
- Parse OGC WKT VLR payloads (record_id 2111/2112) using
las_packed_string(...)so the trailing NUL is optional. - Add reader tests for coordinate WKT (2112) and math-transform WKT (2111), with and without a trailing NUL, and for
wkt()preference/fallback behavior. - Bump the pinned
codecov/codecov-actionSHA to the v7.0.0 release commit.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vlr.hpp |
Clarifies that las_packed_string is also used for WKT payloads where a trailing NUL may be omitted. |
src/las_reader.hpp |
Uses las_packed_string when decoding WKT VLR payloads to support both terminated and unterminated payloads. |
src/tests/test_reader.cpp |
Adds regression tests for WKT parsing across record_id 2111/2112 with/without trailing NUL and validates wkt() selection logic. |
.github/workflows/codecov.yml |
Updates Codecov Action pin to the v7.0.0 commit SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.